-
Notifications
You must be signed in to change notification settings - Fork 38
fix(bugfix): improve implementation pattern guidance - #48
Draft
ambient-code[bot] wants to merge 1 commit into
Draft
fix(bugfix): improve implementation pattern guidance #48ambient-code[bot] wants to merge 1 commit into
ambient-code[bot] wants to merge 1 commit into
Conversation
... feedback Address corrections from session-1771963475 where the agent: 1. Referenced a non-existent patterns file 2. Missed terminal state 'Error' in polling logic 3. Didn't account for React Query keepPreviousData interaction Changes: - Fix skill: Add pre-implementation guidance to search codebase for patterns and verify file paths before referencing them (prevents hallucination) - Fix skill: Add thorough edge case handling guidance including explicit state listing and feature interaction consideration - Diagnose skill: Add guidance to identify complete state sets and verify technical requirements against codebase usage These improvements help prevent incomplete implementations by encouraging systematic codebase searches and explicit enumeration of all states/conditions. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses 3 corrections from session-1771963475 where the agent:
.claude/patterns/react-query-usage.mdfilekeepPreviousDatainteractionChanges
Fix Skill (
workflows/bugfix/.claude/skills/fix/SKILL.md):Diagnose Skill (
workflows/bugfix/.claude/skills/diagnose/SKILL.md):Impact
These improvements help prevent:
By encouraging systematic codebase searches and explicit enumeration of all states/conditions, the workflow now provides better guidance for implementing complete and correct fixes.