Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Add k-means clustering #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
64json merged 1 commit into algorithm-visualizer:master from Jeff-Tian:master
Jan 28, 2021
Merged

feat: Add k-means clustering #27

64json merged 1 commit into algorithm-visualizer:master from Jeff-Tian:master
Jan 28, 2021

Conversation

Copy link
Contributor

@Jeff-Tian Jeff-Tian commented Dec 15, 2020

Hi there!

I'd like to add a new algorithm k-means clustering to this repo, is it appropriate to merge? Please help review, thanks in advance!

The new visualizer needs an extra Scatter Chart, so there are relevant PRs to other repos, please help review them, too.

image

64json reacted with rocket emoji
@64json 64json merged commit 7138698 into algorithm-visualizer:master Jan 28, 2021
Copy link

Hey, gay! Could you please add commas at the end of lines? There are so many errors!

Copy link
Contributor Author

Hey, gay! Could you please add commas at the end of lines? There are so many errors!

Hi gay! Where are the errors? Could you share a screenshot of them?

Copy link

I'm sorry, actually it's ;.

image

Copy link
Contributor Author

I don't think they are errors, and semicolons are optional. But it's good to add them to be consistent with the style in this repo. You could fork and add them and then make a PR. 🥇

Copy link

Let's forget it. There is no big problem even if it is not changed. I'm feeling lazy now.😴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /