-
Notifications
You must be signed in to change notification settings - Fork 88
fix: keep key in child elements, fixes #301 #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+34
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DanielHara
DanielHara
force-pushed
the
fix-issue-301
branch
from
January 30, 2024 22:13
0c20a08 to
7876b72
Compare
@DanielHara
DanielHara
changed the title
(削除) fix key in child elements (削除ここまで)
(追記) fix: keep key in child elements, fixes #301 (追記ここまで)
Jan 30, 2024
@DanielHara
DanielHara
force-pushed
the
fix-issue-301
branch
from
January 30, 2024 22:17
7876b72 to
ce3796c
Compare
@DanielHara
DanielHara
force-pushed
the
fix-issue-301
branch
from
January 30, 2024 22:19
ce3796c to
bb921d1
Compare
@armandabric , any feedback on merging this? :)
@armandabric , any feedback on merging this? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
@armandabric
Fixes #301, test case was added
It's my first contribution, so just let me know if everything is ok according to the guidelines of the project (I didn't find a
CONTRIBUTINGfile), and I'll change the PR accordingly.Thank you very much! 🚀