-
Notifications
You must be signed in to change notification settings - Fork 88
Handle multiple words before trailing space, and after leading space #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jun 29, 2020
There were the following issues with this Pull Request
- Commit: ad977c0
- ✖ message may not be empty
- ✖ type may not be empty
You may need to change the commit messages to comply with the repository contributing guidelines.
🤖 This comment was generated by commitlint[bot]. Please report issues here.
Happy coding!
`/^(\S*)(\s*)$/` will not match if there are multiple words before the trailing space due to it trying to match non-space characters before the trailing space
@kamal
kamal
force-pushed
the
fix-trailing-space-regex
branch
from
June 29, 2020 18:35
ad977c0 to
95e1317
Compare
@kamal
kamal
changed the title
(削除) Handle multiple words before trailing space (削除ここまで)
(追記) Handle multiple words before trailing space, and after leading space (追記ここまで)
Jun 29, 2020
armandabric
armandabric
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you contribution! The code seems good for me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/^(\S*)(\s*)$/will not match if there are multiple words before the trailing space due to it trying to match non-space characters before the trailing space.Without the fix, the following test will fail
image