Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(typescript): Add TypeScript declaration file. Closes #474 #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armandabric merged 7 commits into algolia:master from goloroden:patch-1
Dec 29, 2019
Merged

feat(typescript): Add TypeScript declaration file. Closes #474 #475

armandabric merged 7 commits into algolia:master from goloroden:patch-1
Dec 29, 2019

Conversation

Copy link
Contributor

@goloroden goloroden commented Nov 22, 2019
edited
Loading

Hey there πŸ‘‹

As suggested in #474 there is currently a TypeScript declaration file missing. Hence I added one. If you want to, please feel free to merge it 😊

Copy link

ghost commented Nov 22, 2019

There were the following issues with this Pull Request

  • Commit: d0a69e3
    • βœ– message may not be empty
    • βœ– type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


πŸ€– This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@goloroden goloroden changed the title (ε‰Šι™€) Add TypeScript declaration file. (ε‰Šι™€γ“γ“γΎγ§) (追記) feat(typescript): Add TypeScript declaration file. (θΏ½θ¨˜γ“γ“γΎγ§) Nov 22, 2019
Copy link

ghost commented Nov 22, 2019

There were the following issues with this Pull Request

  • Commit: d0a69e3
    • βœ– message may not be empty
    • βœ– type may not be empty
  • Commit: 4d0f907
    • βœ– message may not be empty
    • βœ– type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


πŸ€– This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@goloroden goloroden marked this pull request as ready for review November 22, 2019 21:42
@goloroden goloroden changed the title (ε‰Šι™€) feat(typescript): Add TypeScript declaration file. (ε‰Šι™€γ“γ“γΎγ§) (追記) feat(typescript): Add TypeScript declaration file. Closes #474 (θΏ½θ¨˜γ“γ“γΎγ§) Nov 22, 2019
Copy link
Contributor Author

Is there any chance that this will get merged eventually?

Copy link
Collaborator

@armandabric armandabric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @goloroden πŸ––

Thanks for this! Everything looks fine for me, lets merge it πŸ˜„

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armandabric armandabric armandabric approved these changes

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle γ«γ‚ˆγ£γ¦ε€‰ζ›γ•γ‚ŒγŸγƒšγƒΌγ‚Έ (->γ‚ͺγƒͺγ‚ΈγƒŠγƒ«) /