Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: ignore test files when publishing #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armandabric merged 2 commits into algolia:master from tisoap:fix/ignore-tests
Oct 8, 2019
Merged

chore: ignore test files when publishing #437

armandabric merged 2 commits into algolia:master from tisoap:fix/ignore-tests
Oct 8, 2019

Conversation

Copy link
Contributor

@tisoap tisoap commented Oct 6, 2019

Looking for simple issues to help with for Hacktoberfest, I stumbled upon this repo 🙂

This PR fixes issue #414

armandabric reacted with thumbs up emoji armandabric reacted with hooray emoji
@armandabric armandabric self-assigned this Oct 7, 2019
Copy link
Collaborator

@armandabric armandabric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution on this 👍 Greatly appreciated 😄

@@ -4,5 +4,6 @@
.flowconfig
.travis.yml
src/
tests/
Copy link
Collaborator

@armandabric armandabric Oct 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the **/*.spec.js and **/*.spec.js.flow patterns to also prevent the unit tests files to be published?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

Copy link

ghost commented Oct 8, 2019

There were the following issues with this Pull Request

  • Commit: a0fed14
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

Copy link
Collaborator

@armandabric armandabric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍

tisoap reacted with laugh emoji
@armandabric armandabric merged commit 22b0493 into algolia:master Oct 8, 2019
@tisoap tisoap deleted the fix/ignore-tests branch October 8, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armandabric armandabric armandabric approved these changes

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /