-
Notifications
You must be signed in to change notification settings - Fork 88
chore(build): replace babel-preset-es2015 by @babel/preset-env #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
armandabric
merged 4 commits into
algolia:master
from
armandabric:support/babel-preset-env
Sep 18, 2019
Merged
chore(build): replace babel-preset-es2015 by @babel/preset-env #351
armandabric
merged 4 commits into
algolia:master
from
armandabric:support/babel-preset-env
Sep 18, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import sortObject from './sortObject';
import parseReactElement from './../parser/parseReactElement';
import formatTreeNode from './formatTreeNode';
import formatFunction from './formatFunction';
import spacer from './spacer';
import type { Options } from './../options';
// Rollup fail to correctly import `stringify-object` so we have to use a workaround
const stringify = (...args) => stringifyObject.default(...args);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closed
This also unlock the upgrade to jest v24 and rollup v1
@armandabric
armandabric
force-pushed
the
support/babel-preset-env
branch
from
September 16, 2019 06:56
8e55ab9 to
13553c6
Compare
- Compare the bundle before/after this PR to ensure everything is OK
@armandabric
armandabric
force-pushed
the
support/babel-preset-env
branch
from
September 18, 2019 07:37
44a0745 to
c991ca5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This also unlock the upgrade to jest v24 and rollup v1
This PR will fix #299, fix #304, fix #313, fix #334, fix #341 and fix #350
We will get rid of these staging PR 💪