-
Notifications
You must be signed in to change notification settings - Fork 5.3k
feat(AcePopup): adding getDataContainer and setVisibleRows methods #5708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #5708 +/- ## ======================================= Coverage 87.02% 87.02% ======================================= Files 598 598 Lines 43593 43613 +20 Branches 7163 7163 ======================================= + Hits 37936 37956 +20 Misses 5657 5657
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a reason for exposing renderer.$textLayer.element here and not, for example, renderer.content or render.scroller? (which encompass all layers of the popup and might allow more flexibility when styling the popup)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use popup.setOption("maxLInes", rows) instead of adding new api?
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts) and its references: