Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: jinja highlighter #5639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
blaggacao wants to merge 2 commits into ajaxorg:master
base: master
Choose a base branch
Loading
from blaggacao:feat/jinja-syntax
Draft

Conversation

@blaggacao
Copy link

@blaggacao blaggacao commented Sep 8, 2024

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link
Author

@akoreman Hey! Could you help me get set up with a suitable review buddy? This is a first draft, but I'm happy and going to dogfood it in (less critical parts of) production.

Anything that comes up during the test phase, will be amended by my own initiative.

It would be nice to have a preliminary review on the patterns and implementation choices as I was mildly confused by the codbase and how to get a handle on it, so I basically did educated guessing and copy pasting and a lot of long iterations.

I'd hope with some expert eyes on it, the low hanging fruits for improvement can be taken already.

Comment on lines +38 to +40
if (this.mayBeJinjaVariable(token)) {
return this.getVariableCompletions(state, session, pos, prefix);
}
Copy link
Author

@blaggacao blaggacao Sep 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: remove. Or better, still: detect variables of for loops or set directives.

But how?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /