-
Notifications
You must be signed in to change notification settings - Fork 5.3k
feat: jinja highlighter #5639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: jinja highlighter #5639
Conversation
blaggacao
commented
Sep 8, 2024
@akoreman Hey! Could you help me get set up with a suitable review buddy? This is a first draft, but I'm happy and going to dogfood it in (less critical parts of) production.
Anything that comes up during the test phase, will be amended by my own initiative.
It would be nice to have a preliminary review on the patterns and implementation choices as I was mildly confused by the codbase and how to get a handle on it, so I basically did educated guessing and copy pasting and a lot of long iterations.
I'd hope with some expert eyes on it, the low hanging fruits for improvement can be taken already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: remove. Or better, still: detect variables of for loops or set directives.
But how?
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts) and its references: