Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Resolving #283 user warning when delay_after_gen is not in use #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
greenLeopard wants to merge 1 commit into ahmedfgad:master from greenLeopard:master

Conversation

Copy link

@greenLeopard greenLeopard commented Jul 17, 2024 •
edited
Loading

I've made three small changes to remove the UserWarning without suppressing all warnings (#283 ).

  1. In the constructor, set the default value for delay_after_gen to None.
  2. In the validation step, if the incoming argument is None, set self.delay_after_gen to None.
  3. Before calling time.sleep(self.delay_after_gen) just check whether it's None.

Although, the alternative, since it's being deprecated, is to remove all references to delay_after_gen. I'll be happy to do that if it's your preference, then I'll resubmit the PR.

ahmedfgad reacted with heart emoji
@ahmedfgad ahmedfgad added the enhancement New feature or request label Jan 7, 2025
Copy link
Owner

Thank you but the delay_after_gen attribute will be removed in the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /