-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
casey-brooks
commented
Apr 14, 2026
Test & Lint Summary
- Commands:
- buf lint
- buf build
- buf breaking --against '.git#branch=main'
- Tests: passed 2, failed 0, skipped 0
- Lint status: no errors
@noa-lucent
noa-lucent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proto changes themselves (adding name to InitScript, CreateInitScriptRequest, and UpdateInitScriptRequest) look structurally correct — field numbers are properly assigned, optional is used appropriately for the update message, and the additions are wire-compatible.
However, the PR claims to close #91, which is an entirely different issue (runner/app re-enrollment proto changes). This must be corrected before merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[major] Wrong issue linked. This PR references #91 (runner/app re-enrollment proto changes in ziti_management.proto and runners.proto), but the actual changes add a name field to init script messages in agents.proto — completely unrelated.
Please update the PR description to link the correct issue, or remove the Closes #91 reference if there's no corresponding issue for this change.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Testing
Related to agynio/agynd-cli#91