-
Notifications
You must be signed in to change notification settings - Fork 2
Comments
Open
Conversation
Collaborator
densetsuuu
commented
Jul 22, 2025
Hey ! Thanks for the PR, it's a very good idea 🙌
We try to keep the code as consistent as possible, could you fix the make:router command to use the already existing code ? Like for example the checkModule function from the src/utils.
For the stub, look at the make:controller command for example, we need to pass the flags to the stubs to avoid side effets, we try to extend the make commands, not replace them
One last thing regarding the module router, will the routes defined inside be registered by AdonisJS if you don't edit the .adonisrcfile ?
Once again, apart from these details, great work ! 🥇
Author
tianjos
commented
Jul 25, 2025
H!, @densetsuuu!
Since this command doesn't exists officially, I follow the guidelines of module command.
I forgot adonisrc file totally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi There!
This PR provide make:router by module command.
Hope this may be helpful