-
Notifications
You must be signed in to change notification settings - Fork 1
app-admin/rex: Initial ebuild with adjust patches - #534
Merged
Merged
Conversation
xmhd
commented
Feb 18, 2021
Contributor
LGTM. I will test it out locally today.
alip
commented
Mar 9, 2021
Contributor
Author
After discussing with upstream we decided submitting two of the patches as modules to CPAN is a better idea.
I'll adapt this PR accordingly hence s/review/in progress/ for the time being.
Package-Manager: Portage-3.0.8, Repoman-2.3.11
alip
force-pushed
the
rex-1-13-2-with-adjust-patches
branch
from
March 9, 2021 14:43
e0e0e9c to
49b3d80
Compare
Package-Manager: Portage-3.0.8, Repoman-2.3.11
Package-Manager: Portage-3.0.8, Repoman-2.3.11
Package-Manager: Portage-3.0.8, Repoman-2.3.11
alip
commented
Mar 9, 2021
Contributor
Author
Updated adjust patches and added initial ebuilds for Rex-Interface-Shell-I{drac4,lo}.
alip
commented
Mar 9, 2021
Contributor
Author
Note: add Rex-Interface-Shell-I{drac4,lo} to adjust-infrastructure meta package once #542 is merged.
xmhd
commented
Jun 3, 2021
Contributor
have been using this for a bit, and seems to be working fine.
I am merging this PR and will update the infrastructure package with || ( app-admin/rex app-admin/trex ) and we can keep trex around for bit before we decide to remove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package-Manager: Portage-3.0.8, Repoman-2.3.11
This is rex-1.13.2 plus the adjust patches which have been included in trex-1.6.0.4 except RexOps/Rex#1471 which has been in trex master. I have carefully reviewed the changeset between current trex and latest rex and filtered out the patches which have already been fixed upstream. I have been testing this without issues for a couple of days now and there're no critical changes between the two versions so I'm relatively confident this won't kill your kittens. Still, you've been warned. Submitting this pull request with the hope to get wider testing. Note you have to uninstall trex before installing rex as they're blocking each other obviously due to file collisions.
The ebuild is identical to the one in gentoo-x86 except for the change below:
gentoo-overlay/app-admin/rex/rex-1.13.2.ebuild
Lines 101 to 108 in e0e0e9c
All patches listed above have already been submitted upstream.
Current process of unforking can be tracked here: adjust/Rex#28.
This pull request obsoletes #474.