Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add type hints#133

Merged
shima004 merged 1 commit into
main from
fix/type-hint
Mar 31, 2026
Merged

Add type hints #133
shima004 merged 1 commit into
main from
fix/type-hint

Conversation

@shima004

@shima004 shima004 commented Mar 31, 2026

Copy link
Copy Markdown
Member

This pull request makes minor improvements to type safety and logging clarity in the abstract_module.py file. The changes add explicit type annotations to several class attributes and update the logger's type for better code readability and maintainability.

Key improvements:

Type annotation enhancements:

  • Added explicit type annotations to class attributes such as self._agent_info, self._world_info, self._scenario_info, self._module_manager, and self._develop_data in the __init__ method to improve type safety and clarity.

Logging improvements:

  • Imported BoundLogger from structlog.stdlib and annotated self._logger as a BoundLogger to clarify the logger's type. [1] [2]

@shima004 shima004 self-assigned this Mar 31, 2026
@shima004 shima004 merged commit 26ec4fe into main Mar 31, 2026
4 checks passed
@shima004 shima004 deleted the fix/type-hint branch March 31, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /