-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
anonrig
anonrig
reviewed
Mar 12, 2024
anonrig
anonrig
reviewed
Mar 12, 2024
.PHONY: requirements
ci_requirements:
python3 -m pip install uv
python3 -m uv pip install --system -r requirements/development.txt
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
python3 -m uv pip install --system -r requirements/development.txt
uv pip install --system -r requirements/development.txt
anonrig
anonrig
reviewed
Mar 12, 2024
.PHONY: requirements
requirements:
python3 -m pip install uv
python3 -m pip install -r requirements/development.txt
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be changed as well
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have it this way to avoid making assumptions about the user's virtual environment setup. It's fine for our CI target, though.
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
Open
bbayles
commented
Feb 26, 2025
Collaborator
Author
The blockers for this have resolved on the uv side, so this can happen now.
CarlosEduR
commented
Feb 28, 2025
Member
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes our
Makfileto useuv pipinstead ofpip.Resolves #58