-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(artifact): downgrade zero-byte upload warning to debug#2412
Open
jjoseph456 wants to merge 1 commit into
Open
fix(artifact): downgrade zero-byte upload warning to debug #2412jjoseph456 wants to merge 1 commit into
jjoseph456 wants to merge 1 commit into
Conversation
When uploading a zero-byte file with skipArchive:true, a spurious warning is emitted even though the upload completes successfully. Zero-byte files are a valid use case (e.g. marker files, lock files) and the upload is finalized correctly with size 0. Downgrade from core.warning() to core.debug() so the message is still available for troubleshooting but doesn't pollute workflow output. Fixes actions#2333 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When uploading a zero-byte file with
skipArchive: true, a warning is emitted even though the upload completes successfully:Zero-byte files are a valid use case (marker files, lock files, empty placeholders) and the upload finalizes correctly with
size: 0.Fix
Downgrade
core.warning()tocore.debug()so the message remains available for troubleshooting but doesn't pollute workflow output for legitimate zero-byte uploads.Related
Fixes #2333
Related: actions/upload-artifact#777