-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Open
Conversation
Signed-off-by: Andrey Dodonov <Andrey.Dodonov@endress.com>
@AndreyDodonov-EH
AndreyDodonov-EH
requested a review
from a team
as a code owner
May 13, 2026 11:22
danwkennedy
commented
May 28, 2026
Contributor
@AndreyDodonov-EH thanks for catching this! Are you able to add tests for this change? If not, I'll take a stab at it and find another approver.
AndreyDodonov-EH
commented
Jun 2, 2026
Author
@AndreyDodonov-EH thanks for catching this! Are you able to add tests for this change? If not, I'll take a stab at it and find another approver.
@danwkennedy
Added 2 tests (would fail on main, pass with this branch - incomplete download detection and response stream error propagation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes one of the potential root causes for actions/download-artifact#454, and related actions/download-artifact#475 and possibly actions/download-artifact#326
Adds error propagation and error on length mismatch
npm run format,npm run lintandnpm testfor the artifact package were run.