-
Notifications
You must be signed in to change notification settings - Fork 195
Comments
Add PHP 8.5 support, remove 8.3 from tests#10366
Open
Add PHP 8.5 support, remove 8.3 from tests #10366
Conversation
@github-actions
github-actions
bot
added
RaisinBread
PR or issue introducing/requiring improvements to the Raidinbread dataset
Language: PHP
PR or issue that update PHP code
labels
Feb 13, 2026
Contributor
MaximeBICMTL
commented
Feb 13, 2026
Note that since PHP 8.4 becomes the minimum supported PHP version of LORIS, you can remove these pieces of code:
Line 37 in ebcc5d9
// TODO: Remove this code once PHP 8.4 becomes the minimal PHP version in LORIS.
Loris/tools/generic_includes.php
Line 21 in ebcc5d9
// TODO: Remove this code once PHP 8.4 becomes the minimal PHP version in LORIS.
Collaborator
Author
driusan
commented
Feb 13, 2026
Thanks, was going to do that but forgot.. now I just need to investigate the failures that the CI caught.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.5 is out and we officially support the latest 2 versions of PHP, so change the tests from 8.3 and 8.4 to 8.4 and 8.5.
Had to fix a few deprecation warnings, but otherwise poking around seemed to mostly work.