-
Notifications
You must be signed in to change notification settings - Fork 195
Comments
[DQT] Fix random scroll jump when deleting selected fields#10361
Open
arnav-makkar wants to merge 1 commit intoaces:main from
Open
[DQT] Fix random scroll jump when deleting selected fields #10361arnav-makkar wants to merge 1 commit intoaces:main from
arnav-makkar wants to merge 1 commit intoaces:main from
Conversation
@github-actions
github-actions
bot
added
the
Module: dataquery
PR or issue related to (new) dataquery module
label
Feb 12, 2026
Collaborator
adamdaudrich
commented
Feb 18, 2026
LGTM
Contributor
Author
arnav-makkar
commented
Feb 19, 2026
Thank you @adamdaudrich
Could you please mark this PR as approved as well so that it can be merged.
Same for all these other PRs that you've already reviewed: #10300 #10304 #10305 #10307
Collaborator
@adamdaudrich
adamdaudrich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Collaborator
adamdaudrich
commented
Feb 19, 2026
please assign me to review them
Contributor
Author
arnav-makkar
commented
Feb 19, 2026
I do not have write access so cannot do that.
@driusan Please confirm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Added
e.stopPropagation()to the delete click handler.Testing
Before:
Screen.Recording.2026年02月13日.at.00.56.09.mov
After:
Screen.Recording.2026年02月13日.at.01.02.41.mov
Link(s) to related issue(s)