-
Notifications
You must be signed in to change notification settings - Fork 195
Comments
statistics: replace $.ajax with lorisFetch#10338
Open
Montekkundan wants to merge 1 commit intoaces:main from
Open
statistics: replace $.ajax with lorisFetch #10338Montekkundan wants to merge 1 commit intoaces:main from
Montekkundan wants to merge 1 commit intoaces:main from
Conversation
@github-actions
github-actions
bot
added
Language: Javascript
PR or issue that update Javascript code
Module: statistics
PR or issue related to statistics module
labels
Feb 5, 2026
@driusan
driusan
added
the
State: Blocked
PR or issue awaiting an external event such as the merge or another PR to proceed
label
Feb 5, 2026
Author
Montekkundan
commented
Feb 10, 2026
reviewed this pr against the new Client guidance and did not push code changes.
- The touched calls in this PR are HTML fragment/tab content requests (
response.text()+ DOM injection), not REST-style JSON data requests. - Per guidance, those flows remain on
lorisFetch. - I can follow up with a separate
Clientmigration if/when JSON endpoints are introduced for these paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
$.ajaxcalls withlorisFetchinstatistics.Why
This removes jQuery AJAX usage in this module for issue #4213.
Scope
Only AJAX replacement in this module. No unrelated jQuery refactors.
Dependency
Depends on PR #10333 .
Verification
git grep '\$\.ajax'is clean for touched files.