-
-
Notifications
You must be signed in to change notification settings - Fork 309
Conversation
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com> Refactor css for tooltip Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
Samk1710
commented
Jun 7, 2026
Attached the following screenshots as reference:
image imageNote:
- In this screenshot, my local postgres has EPSS scores imported from May 30th to June 7th. However, I intentionally skipped importing data for June 4th and June 5th to simulate an import failure or missing upstream data which was a concern in the community call. To address this, I made sure the chart functions as a discrete representation rather than drawing misleading, continuous trend lines as seen in the graph.
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
pombredanne
commented
Jun 17, 2026
@tdruez your input is welcomed on the choice of billboard.js (vs. libraries already in use in ScanCode.io?)
tdruez
commented
Jun 17, 2026
@pombredanne We use billboard.js in SCIO as well.
@pombredanne
pombredanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Samk1710 Thanks... you'll need to resolve merge conflicts. And here are a few things to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this check on the prefix? Is there a better way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why again the same check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure I get what this means: this would be true only on the 1st iteration, and is_latest seems to say the opposite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you instead iterate on severities? this would be cleaner IMHO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is chartwrap? and tablewrap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this variable contain? map feels a pretty non descriptive name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer that all these data handling and data preparation happen in Python and not here in the JS code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also include the non-minified version... also the js is NOT part of the zip you list at all, but part of the npm at https://registry.npmjs.org/billboard.js/-/billboard.js-3.18.0.tgz instead. Please use that version, not some random thing fetched from a CDN.
Also where is d3 coming from in all this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The minified JS bundles D3... Is this really a good thing?
Copyright (c) 2017 ~ present NAVER Corp.
billboard.js project is licensed under the MIT license
billboard.js, JavaScript chart library
@Version 3.18.0
All-in-one packaged file for ease use of 'billboard.js' with dependant d3.js modules & polyfills.
- @types/d3-selection ^3.0.11
- @types/d3-transition ^3.0.9
- d3-axis ^3.0.0
- d3-brush ^3.0.0
- d3-drag ^3.0.0
- d3-dsv ^3.0.1
- d3-ease ^3.0.1
- d3-hierarchy ^3.1.2
- d3-interpolate ^3.0.1
- d3-scale ^4.0.2
- d3-selection ^3.0.0
- d3-shape ^3.2.0
- d3-time-format ^4.1.0
- d3-transition ^3.0.1
- d3-zoom ^3.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this?
Samk1710
commented
Jun 17, 2026
@Samk1710 Thanks... you'll need to resolve merge conflicts. And here are a few things to review.
Thanks @pombredanne for the review. I will go through all your comments and update shortly.
Uh oh!
There was an error while loading. Please reload this page.
Resolves
Tasks Done:
Test log excerpt:
Billboard links: