-
-
Notifications
You must be signed in to change notification settings - Fork 309
Sort vulnerabilities from newest to oldest in API responses#2243
Open
ashwinraj8090 wants to merge 1 commit into
Open
Sort vulnerabilities from newest to oldest in API responses #2243ashwinraj8090 wants to merge 1 commit into
ashwinraj8090 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @pombredanne,
I worked on this issue and implemented descending sorting for vulnerabilities so that newer entries appear first in the API responses.
Approach
Since there is no explicit timestamp field available, I used
vulnerability_idas a proxy for ordering, assuming higher IDs correspond to more recent entries.The sorting has been applied across relevant API querysets, including:
For packages, I did not introduce sorting as there does not appear to be a clear field representing recency. Please let me know if a specific field should be used.
Please let me know if this approach aligns with the intended solution or if a different field or strategy should be preferred.
Fixes #1754
Thank you!