-
-
Notifications
You must be signed in to change notification settings - Fork 309
Open
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds a new v2 importer pipeline to ingest ZyXEL security advisories into the VulnerableCode v2 advisory model, wiring it into the global importers registry and providing fixture-based parsing tests.
Changes:
- Added
ZyxelImporterPipelinewith listing-page URL discovery and advisory-page parsing (CVEs, summary, published date, references, deterministic advisory IDs). - Registered the new pipeline in
IMPORTERS_REGISTRY. - Added parsing tests plus HTML fixtures for listing and advisory pages.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
vulnerabilities/pipelines/v2_importers/zyxel_importer.py |
New ZyXEL v2 importer: fetch listing, discover advisory URLs, parse advisories into AdvisoryDataV2. |
vulnerabilities/importers/__init__.py |
Registers ZyxelImporterPipeline in the importers registry. |
vulnerabilities/tests/pipelines/v2_importers/test_zyxel_importer_pipeline.py |
Adds unit tests for listing/advisory parsing and advisory ID behavior. |
vulnerabilities/tests/test_data/zyxel_v2/security_advisories_listing.html |
Fixture HTML for the advisory listing page. |
vulnerabilities/tests/test_data/zyxel_v2/zyxel_security_advisory_for_foo.html |
Fixture HTML for an advisory detail page (CVE extraction + published date). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Signed-off-by: Tedsig42 <teddams047@gmail.com>
@Tednoob17
Tednoob17
force-pushed
the
feat/zyxel-security-advisories-1839
branch
from
March 19, 2026 16:24
091eb5c to
5d0e823
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new v2 importer for
ZyXELsecurity advisories.Changes
ZyXELimporter pipeline with deterministic advisory IDsValidation
Tests pass: 3 passed, 2 unrelated warnings"