forked from vkurchatkin/deasync
-
-
Notifications
You must be signed in to change notification settings - Fork 73
Open
Conversation
export default & index.d.ts
SnirBroshi
commented
Nov 15, 2020
The throw inside the catch won't really throw outside
papb
papb
reviewed
Nov 15, 2020
Comment on lines
+80
to
+94
done = false;
result = undefined;
pr
.then(function(r) {
done = true;
return result = r;
})
.catch(function(err) {
done = true
throw err
})
deasync.loopWhile(() => { return !done });
return result;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
done = false;
result = undefined;
pr
.then(function(r) {
done = true;
return result = r;
})
.catch(function(err) {
done = true
throw err
})
deasync.loopWhile(() => { return !done });
return result;
done = false;
result = undefined;
error = undefined;
pr
.then(function(r) {
done = true;
result = r;
})
.catch(function(err) {
done = true;
error = err;
})
deasync.loopWhile(function() { return !done; });
if (error) throw error;
return result;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about errors what are falsy? for example Promise.reject(0) or Promise.reject(undefined).
This still would no throw an exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NotWearingPants I forgot that those rejections are technically possible. Indeed to cover that it would be better to use a didThrow variable instead.
loynoir
commented
Nov 10, 2021
deasync.await = p => deasync((cb)=>p.then(x=>cb(null,x),e=>cb(e,null)))()
> deasync.await(import('some-esm-module')) [Module: null prototype] { ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added function deasync.await, that is like await in async function, but works in sync function or global scope.