-
Notifications
You must be signed in to change notification settings - Fork 73
make ifconfig parameters optional#36
Open
Clement-TS wants to merge 1 commit intoabandonware:master from
Open
Conversation
@Clement-TS
Clement-TS
force-pushed
the
master
branch
from
April 3, 2017 09:43
535c18c to
f4ad465
Compare
@Clement-TS
Clement-TS
force-pushed
the
master
branch
from
April 3, 2017 10:03
f4ad465 to
d8dfeb1
Compare
Author
Clement-TS
commented
Mar 7, 2018
@bakerface do you still maintain this project? Is my proposal unuseful?
rzr
rzr
reviewed
Jul 11, 2021
it('should bring up the interface without broadcast nor subnet', function(done) {
ifconfig.exec = function(command, callback) {
should(command).eql('ifconfig wlan0 192.168.10.1 up');
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may this address be used from ENV var?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you just want to up an interface, you don't need to give any networ/broadcast/mask. Usually in your console you just do
ifconfig wlan0 upThat's what I'm suggesting here