-
-
Notifications
You must be signed in to change notification settings - Fork 22
Comments
allow pure build of zig derivation#135
Open
oldaccountdeadname wants to merge 1 commit intoXe:master from
Open
allow pure build of zig derivation #135oldaccountdeadname wants to merge 1 commit intoXe:master from
oldaccountdeadname wants to merge 1 commit intoXe:master from
Conversation
Prior to this commit, if nixpkgs was imported with a definite system, it would *mostly* work as intended and not make impure calls to Nix's builtins.CurrentSystem, except for here in zig_raw.nix, which doesn't respect sources and pkgs. The solution is simple: just inherit sources and pkgs when we make a versioned zig_raw in zig.nix.
oldaccountdeadname
added a commit
to oldaccountdeadname/pahi
that referenced
this pull request
Nov 26, 2021
This consists of two changes: 1. Use rustChannelOf instead of rustChannelOfTargets to supply a sha256 (required for pure eval) 2. Inherit pkgs in olin. Olin is *almost* pure, pending Xe/olin#135.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Just one commit, here's the message:
I've tested that this successfully builds and that tests run, so I don't think this should cause any problems!
This change is Reviewable