-
Notifications
You must be signed in to change notification settings - Fork 146
Comments
Overhaul trophy conditions#6391
Open
Cyperghost wants to merge 18 commits into6.3-condition-notice from
Open
Conversation
...ed via RebuildData.
...his prevents the form from immediately displaying an error message that the Conditions field has not been filled in.
...t (no added condition) returns `false` for this function either.
dtdesign
dtdesign
requested changes
Jul 24, 2025
Member
@dtdesign
dtdesign
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I don’t like how the runtime cache is being used. Littering the code with cache*IDs() is not a solution but a hacky workaround.
Generally speaking, we usually know which trophies are being requested, so why not group them in a collection and fix this instead of making this an afterthought?
wcfsetup/install/files/lib/data/user/trophy/UserTrophyList.class.php
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wcf\data\file\File