-
Notifications
You must be signed in to change notification settings - Fork 146
Comments
Remove deprecated support for ISearchableObjectType#5457
Open
Remove deprecated support for ISearchableObjectType #5457
ISearchableObjectType #5457Conversation
Member
@TimWolla
TimWolla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't meaningfully comment on this, because I didn't really follow the search changes in 5.5. The diff looks not obviously wrong, but that might not mean much.
Member
Author
BurntimeX
commented
Apr 27, 2023
This should possibly be postponed to 6.1 or later, depending on how far the migration to "ISearchProvider" has already been completed by third-party developers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.