-
Notifications
You must be signed in to change notification settings - Fork 2
Preserve C# multiline search origin classification - #5316
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve C# multiline comment, verbatim-string and raw-string origins when searching indexed text. The issue's
ArgumentListexamples no longer pass--origin code. Read bounded indexed prefixes across chunk boundaries, retain source coordinates and schema/help/regex labels, and returnunknownwhen lexical state cannot be established.CLI rows, filtered counts, token-boundary recipes and MCP share the classifier. No database migration or rebuild is required.
Fixes #5307
Validation
dotnet run --project tools/CodeIndex.Changelog -- check..codex/workflows/adversarial-review.md(two rounds). Addressed repeated prefix/schema work and interpolation-opener parity, including the second-round finding for many distinct matched literals. Allocation regressions cover both code matches and 500 string matches; focused regressions were rerun after the final shared-text validation change.Documentation
Updated English and Japanese README, developer-guide and testing-guide sections. Added
changelog.d/unreleased/5307.fixed.md;CHANGELOG.mdis unchanged. Agent entry points andAGENT_GUIDE.mdare unchanged.Follow-ups
None outside this issue. Missing/budget-limited prefixes and text at/after interpolation expressions retain the documented
unknownorigin; inspect those results without a code-origin filter.