Skip to content

Navigation Menu

Sign in
Sign up

[SFA] Improve Quick Start - #997

Open
AyushBherwani1998 wants to merge 3 commits into
master from
quick-start-fix
Open

[SFA] Improve Quick Start #997
AyushBherwani1998 wants to merge 3 commits into
master from
quick-start-fix

Conversation

@AyushBherwani1998

@AyushBherwani1998 AyushBherwani1998 commented Nov 22, 2024

Copy link
Copy Markdown
Member

Motivation and Context

Jira Link:

Description

Adds the create Firebase Verifier links instead generic verifier step

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

vercel Bot commented Nov 22, 2024
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2024 5:05pm

@shahbaz17 shahbaz17 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


import VerifierDashboard from "@site/static/images/dashboard/create-verifier.png";

One of the prerequisites of using this SDK, is the creation of a custom verifier. This can be done

@shahbaz17 shahbaz17 Dec 11, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get started with this SDK, you’ll need to create a custom verifier. Don’t worry—it’s a simple process! You can set it up quickly by enabling custom authentication in your Web3Auth Dashboard. In this guide, we’ll walk you through using Firebase as our Auth Provider to make everything seamless and straightforward.

Can go with easy and inviting sentences, please take a look once

@yashovardhan yashovardhan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your idea is good, but need to change the content in a way that people think other providers are also supported.

@yashovardhan yashovardhan Dec 23, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too much focused on Firebase, we do not want people to perceive the that the SDK only works with Firebase. We want generic content here.

@yashovardhan yashovardhan Dec 23, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also web one uses google one tap

@shahbaz17 shahbaz17 added the blocked The PR is blocked, please don't merge label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yashovardhan yashovardhan yashovardhan left review comments
@shahbaz17 shahbaz17 shahbaz17 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

blocked The PR is blocked, please don't merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /