-
Notifications
You must be signed in to change notification settings - Fork 278
Long Node names truncated issue resolved in WebVOWL - #188
Open
nandikajain wants to merge 1 commit into
Open
Conversation
nandikajain
commented
May 10, 2022
Contributor
Author
AbsoluteTextElement.prototype.addText = function ( text, yShift, prefix, suffix ){
if ( text ) {
this.addTextline(text, this.CSS_CLASSES.default, yShift, prefix, suffix);
AbsoluteTextElement.prototype.addText = function (text, yShift, prefix, suffix) {
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main changes are done there. Rest all are due to the formatter in VSCode.
nandikajain
commented
May 11, 2022
Contributor
Author
@vitalis-wiens The only 2 files that I changed are AbsoluteTextElement.js and CenteringTextElement.js
The package-lock.json got updated on its own, and the rest of the changes are formatting changes which add indentation and line space done by linting in vscode.
L4B0MB4
commented
Jan 3, 2023
While this repo is more or less unactive I checked out the PR and it seems there is still something that need to be done as textoverlow now happens on nodes that are too small
image
Zack-83
Zack-83
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82
As pointed out in the issue thread, I have implemented the solution where the names are split based on the whitespace and each word is then displayed in separate lines.
The issues arises here in src/webvowl/js/util/:
Here, the text is truncated. If we split the text based on the white spaces and then call
addTextLine, the issue gets resolved.Screenshots:
Before:
before_update
After:
after_update