-
Notifications
You must be signed in to change notification settings - Fork 229
Mitigate PageIndex file-descriptor buildup during long PDF indexing#44
Open
plasma16 wants to merge 8 commits into
Open
Mitigate PageIndex file-descriptor buildup during long PDF indexing #44plasma16 wants to merge 8 commits into
plasma16 wants to merge 8 commits into
Conversation
Fix XLSX ingestion memory spikes with streaming parser
KylinMountain
commented
May 12, 2026
Collaborator
@plasma16 Thank you for your contribution. However, this PR introduces changes to other functionalities. Could you please scope this PR to only address the current feature? Thank you.
KylinMountain
pushed a commit
that referenced
this pull request
Jun 12, 2026
litellm caches aiohttp clients per event loop. add_single_file runs each doc via a fresh asyncio.run() loop, so the previous loop's clients are abandoned and their HTTP connections linger in CLOSE-WAIT, accumulating sockets/FDs over a long ingest (observed 200+ against a remote API on a 165-doc run). Add _close_litellm_async_clients() (best-effort, never raises) and call it in try/finally around index_long_document and both compile_short_doc / compile_long_doc calls. Verified: CLOSE-WAIT returns to ~0 after each doc. Supersedes the now-stale #44 (which carried the same intent on an old base).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Purpose
Reduce risk of
[Errno 24] Too many open filesduring long-PDF indexing with retries.Changes
openkb/indexer.py.PageIndexClientper retry attempt.gc.collect()between failed attempts to accelerate descriptor release in long runs.Why this helps
In local mode, repeated failed/retried indexing can leave resources alive longer than expected. This patch ensures resources are released promptly per attempt.
Test evidence
python3 -m py_compile openkb/indexer.py(pass)pytestis not installed in system Python.Notes
This is an OpenKB-side mitigation while upstream
pageindexresource handling can be further hardened.