-
Notifications
You must be signed in to change notification settings - Fork 462
fix: network manager does not clean up if exception is thrown while starting #3864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
NoelStephensUnity
wants to merge
1
commit into
develop-2.0.0
from
fix/3552-networkmanager-fails-to-cleanup-if-exception-thrown-during-start
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the issue where NetworkManager would not clean up if an exception was thrown while it was starting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Purpose of this PR
Fixes the issue where NetworkManager would not clean up if an exception was thrown while it was starting. This could result in a host or server not completing the start process yet would still have internal systems (i.e.
NetworkConnectionManager,NetworkMessageManager, andUnityTransport) initialized. If a client attempted to connect to a server or host in this state it could result in the server or host logging the following error message:[Netcode] A ConnectionRequestMessage was received from the server on the client side.
Jira ticket
MTT-13631
fix: #3552
Changelog
NetworkManagerwas not cleaning itself up if an exception was thrown while starting.Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
TBD