chore: update usage of deprecated FindObjectsByType<T>(FindObjectsSortMode) and enum FindObjectSortMode #3857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

NoelStephensUnity wants to merge 16 commits into develop-2.0.0

from chore/findobjectsbytype-no-more-sorting-update

Open

chore: update usage of deprecated FindObjectsByType<T>(FindObjectsSortMode) and enum FindObjectSortMode #3857

NoelStephensUnity wants to merge 16 commits into develop-2.0.0 from chore/findobjectsbytype-no-more-sorting-update

+151 −195

Conversation

@NoelStephensUnity

Copy link

Member

@NoelStephensUnity NoelStephensUnity commented Jan 26, 2026 •

edited

Loading

WIP-TODO:

This PR depends upon the trunk PR-89134 to be merged before determining:
- The version of trunk that PR-89134 will be included in.
This PR currently uses 600050a8 as the minimum version, for 6000.5, where the updates to account for the deprecated enum and methods in order to pass tests.
- If PR-89134 is merged into 600050a7, then one more adjustment to the asmdef files will be required.

Purpose of this PR

Making adjustments to the changes in FindObjectsByType. Funneling all find object related calls into a single static method in order to simplify the current, and any future, updates/changes to FindObjectsByType.

Jira ticket

MTT-14339

Changelog

Changed: Updating usage of deprecated FindObjectsByType(FindObjectsSortMode) and enum FindObjectSortMode.

Documentation

No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

Manual testing done
- Verify earlier versions of 6000.4 and 6000.5 work as expected
  - Open test project in 6000.4.b5 or earlier to verify NGO uses the (now deprecated) UnityEngine.FindObjectsSortMode.
  - Open test project in 6000.5.a6 or earlier to verify NGO uses the (now deprecated) UnityEngine.FindObjectsSortMode.
- Verify newer versions of 6000.4 and 6000.5 work as expected
  - Open test project in 6000.4.b6 or later to verify NGO no longer uses UnityEngine.FindObjectsSortMode.
  - (WIP) Open test project in 6000.5.a7/a8 or later to verify NGO no longer uses UnityEngine.FindObjectsSortMode.
    - Waiting on PR-89134.

Automated tests:

Covered by existing automated tests
Covered by new automated tests

Does the change require QA team to:

Review automated tests?
Execute manual tests?
Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Backports

No back port required since this is specific to 6000.4 & 6000.5.

@NoelStephensUnity


 update

b5bff02

Funneling all find object related calls into a single static method in order to simplify the current, and any future, updates/changes to FindObjectsByType.

@NoelStephensUnity NoelStephensUnity requested review from a team and EmandM as code owners

January 26, 2026 20:45

NoelStephensUnity added 4 commits

January 26, 2026 14:49

@NoelStephensUnity


 update

793bade

Making FindObjects internal.

@NoelStephensUnity


 update

c8f54c9

Adjusted to explicit handling of the update within test project script to avoid having to make FindObjects public.

@NoelStephensUnity


 update

a5719db

Adding [MethodImpl(MethodImplOptions.AggressiveInlining)] attribute to the T[] FindObjectsByType<T>() method.

@NoelStephensUnity


 style

fec5e65

Removing unused using directives.
Removing CR.

EmandM

EmandM reviewed

Jan 26, 2026

View reviewed changes

Copy link

Member

@EmandM EmandM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love love love this cleanup! :godmode:

com.unity.netcode.gameobjects/Runtime/Core/FindObjects.cs Show resolved Hide resolved

com.unity.netcode.gameobjects/Tests/Runtime/Prefabs/NetworkPrefabHandlerTests.cs Outdated Show resolved Hide resolved

testproject/Assets/Tests/Manual/SceneTransitioningAdditive/NetworkManagerMonitor.cs Outdated Show resolved Hide resolved

testproject/Assets/Tests/Manual/Scripts/NetworkPrefabPool.cs Outdated Show resolved Hide resolved

NoelStephensUnity and others added 2 commits

January 26, 2026 16:07

@NoelStephensUnity @EmandM


 Update com.unity.netcode.gameobjects/Runtime/Core/FindObjects.cs

db390f5

Co-authored-by: Emma <emma.mcmillan@unity3d.com>

@NoelStephensUnity


 update

9a5d04b

Adding same condition define, NGO_FINDOBJECTS_NOSORTING, to the testproject.manualtests assembly define.

mnachury-unity

mnachury-unity approved these changes

Jan 26, 2026

View reviewed changes

NoelStephensUnity added 6 commits

January 27, 2026 13:13

@NoelStephensUnity


 update

a5983f7

Added more precise Unity engine versions to asmdef files to assure earlier versions of 6000.4 and 6000.5 still use the previous API.
Renamed FindObjects.FindObjectsByType to FindObjects.ByType
Updated FindObject.ByType to be able to sort by identifier and include inactive objects.

@NoelStephensUnity


 Merge branch 'develop-2.0.0' into chore/findobjectsbytype-no-more-sor...

b52e907

...ting-update

@NoelStephensUnity


 update

1f7e70c

Adding sort by identifier to two locations that require sorting by identifier.

@NoelStephensUnity


 style

01dd8c0

Added missing whitespace

@NoelStephensUnity


 update

b53de7a

increasing the 6000.5 version from 5.0a6 to 5.0a7 as it appears trunk is currently 5.0a6 (which doesn't have the deprecation merged into it yet).

@NoelStephensUnity


 update

1a5bb4a

updating minimum for deprecated fix to 600050a8.

RikuTheFuffs

RikuTheFuffs reviewed

Jan 28, 2026

View reviewed changes

com.unity.netcode.gameobjects/Runtime/Unity.Netcode.Runtime.asmdef

Comment on lines +90 to +99

{

"name": "Unity",

"expression": "[600040b5,600050a1)",

"define": "NGO_FINDOBJECTS_NOSORTING"

{

"name": "Unity",

"expression": "600050a8",

"define": "NGO_FINDOBJECTS_NOSORTING"

Copy link

Contributor

@RikuTheFuffs RikuTheFuffs Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you implemented this retro-compatibility fix to avoid compilation errors on alpha/beta versions that didn't have the deprecation change yet, but do we intend to support those versions in the long run?

The risk I foresee is that we fill our code with a bunch of defines for "almost-dead code", with an increased maintenance burden for us, and higher rissk to introduce bugs as we have to support multiple workflows.

Copy link

Member Author

@NoelStephensUnity NoelStephensUnity Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making it work with earlier versions actually prevents users that have yet to upgrade their editor from breaking if they decide to upgrade to the current version of NGO (whichever version that will be once this PR is merged). Otherwise, it would be considered a breaking change for earlier 6000.4 & 6000.5 versions.

But yeah... that is a good point and one of the reasons why I migrated all of the changes into the single FindObjects.ByType<T> method... so there is one place that handles this which also reduces the number of times we have to use the conditional define.

Test project had two places that I added this to in order to prevent from having to make FindObjects public.

Copy link

Member

@EmandM EmandM Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also do the work to remove the scripting defines once we no longer support that Unity version. So these defines won't live forever

EmandM

EmandM approved these changes

Jan 28, 2026

View reviewed changes

Copy link

Member

@EmandM EmandM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love love love the latest name here! :godmode:

NoelStephensUnity added 3 commits

January 28, 2026 14:32

@NoelStephensUnity


 update

f5f5cf2

This "should" fix the Rust server issue... I think?
(Tested local instance on 600050a7 and it passes everything)

@NoelStephensUnity


 Merge branch 'develop-2.0.0' into chore/findobjectsbytype-no-more-sor...

9939aa6

...ting-update

@NoelStephensUnity


 update

5b4f42d

adding change log entry

Labels

None yet

5 participants

@NoelStephensUnity @EmandM @RikuTheFuffs @mnachury-unity

chore: update usage of deprecated FindObjectsByType<T>(FindObjectsSortMode) and enum FindObjectSortMode #3857

Are you sure you want to change the base?

chore: update usage of deprecated FindObjectsByType<T>(FindObjectsSortMode) and enum FindObjectSortMode #3857

Conversation

@NoelStephensUnity NoelStephensUnity commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Jira ticket

Changelog

Documentation

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Backports

Uh oh!

@EmandM EmandM left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

@RikuTheFuffs RikuTheFuffs Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

@NoelStephensUnity NoelStephensUnity Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

@EmandM EmandM Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

@EmandM EmandM left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

@NoelStephensUnity NoelStephensUnity commented Jan 26, 2026 •

edited

Loading