This repository was archived by the owner on Nov 30, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 739
Fixed ReloadBaseTypes being called 2 times when entering play mode#832
Open
PierreGac wants to merge 37 commits into
Open
Fixed ReloadBaseTypes being called 2 times when entering play mode #832PierreGac wants to merge 37 commits into
PierreGac wants to merge 37 commits into
Conversation
Fixes an issue with MultiScaleVO showing incorrectly if XR and single pass stereo is enabled for a project, but the current camera not actually doing stereo rendering, like the scene view or when the HMD isn't active, or for "social" camera views.
...mode. The same thing occurs with EditorUtilities.ReloadDecoratorTypes, but the fix cannot be applied in this context.
@PierreGac
PierreGac
force-pushed
the
v2
branch
from
September 6, 2019 08:03
ada56a3 to
7cba7a0
Compare
...g/tree/patch-1' into v2 # Conflicts: # PostProcessing/Runtime/Effects/MultiScaleVO.cs
... issue fix from manutoo
# Conflicts: # PostProcessing/Shaders/Builtins/ScreenSpaceReflections.hlsl Added .gitattributes from ypapouin@cc0a269 Added pull request Unity-Technologies#854
...cd0d45 => WARNING: When adding a custom effect, you need to add it to the PostProcessManager
Updated package.json
==> NOTE: Adding all changes by this commit will break the enable/disable behavior on the PostProcessVolume (need investigations) Added changes from Tspk91@d3a2830
Revert package relative path of includes in shaders (to keep the good old .package approach working)
# Conflicts: # PostProcessing/Runtime/PostProcessLayer.cs
...464837a3c607488d984
- Unity-Technologies/Graphics@f9b266d#diff-4646e2506088c41089376afacad4fb00432d3b1d463170bf9106c009b68b514e - Unity-Technologies/Graphics@23837ac#diff-4646e2506088c41089376afacad4fb00432d3b1d463170bf9106c009b68b514e - Unity-Technologies/Graphics@a54b10e#diff-4646e2506088c41089376afacad4fb00432d3b1d463170bf9106c009b68b514e
Added pull request : Unity-Technologies/Graphics#7489
...set) and a "normal" camera rendering on the main screen. The main screen would have artifacts. This have been fixed with the RuntimeUtilities.IsSinglePassStereoEnabledOnCamera method Added a new MSVO parameter "disableOnVRCameras", that disables the AO calculation for VR camera, since MSVO is not working on them. Saving a tiny amount of CPU time. => MSVO needs to be reworked to work with VR
Added other github pull requests / commits
...ebd47729d0509754a5b8bf175
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that when entering in playmode, the
ReloadBaseTypes()is called 2 times:instance.ReloadBaseTypes()=> when the instance is null a new one will be created. Inside the ctor, at the end,ReloadBaseTypes()is called first. Then called again by the returned instance (instance.ReloadBaseTypes().This fix will avoid such thing to happen.
The same issue occurs with EditorUtilities.ReloadDecoratorTypes but the previous fix cannot be applied (execution order is unclear)