Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Nov 30, 2020. It is now read-only.

FogEffect#513

Closed
OndrejPetrzilka wants to merge 1 commit into
Unity-Technologies:v2 from
OndrejPetrzilka:FogEffect
Closed

FogEffect #513
OndrejPetrzilka wants to merge 1 commit into
Unity-Technologies:v2 from
OndrejPetrzilka:FogEffect

Conversation

@OndrejPetrzilka

@OndrejPetrzilka OndrejPetrzilka commented Apr 2, 2018
edited
Loading

Copy link
Copy Markdown

Renamed original Fog to DeferredFog (because it is only deferred effect)
Added Fog effect which modifies RenderSettings before rendering and restores after rendering

Related to #512

Implementation consists of three parts

  1. Loading base fog values from RenderSettings in PostProcessEffectSettings.Reset.
  2. Applying fog to RenderSettings in OnPreCull
  3. Restoring original RenderSettings fog values in OnPostRender

Loading base values is necessary for overrides to work properly. We want overrides to work 'on top' of settings which are in RenderSettings.

What works

  • Fog settings
  • Overrides
  • Consistent fog on transparent and opaque materials
  • Different fog on multiple cameras
  • Fog blending between volumes
  • Preview in scene view (image effects/fog)

Possible issues

  • Baking lights?
  • GI (Enlighten)?

Not sure how light baking and Enlighten GI works, it might use fog from global RenderSettings for some calculations.

Added Fog effect which modifies RenderSettings before rendering and restores after rendering

Copy link
Copy Markdown
Author

Closed in favor of better solution #514

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /