-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update the projects to entities 1.0.0-exp.8 #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot add my reviews in the code because the PR is so big that the github interface becomes unresponsive. I'll put them here instead. I'm only reviewing the core entities samples, the other packages should be reviewed by their respective teams.
- The package com.unity.ai.navigation has been added to the project, that doesn't look intentional.
- I don't think the blob asset samples have been updated, they should probably be removed for now. I'll check with Anne.
- The FixedTimestepSystemUpdate sample doesn't work but afaik this one is okay on the internal repo, we should figure this one out. I'll have a look.
- The VirtualMemory sample is pointless and should be deleted, Bryan gave his approval. It's my fault it hasn't been deleted yet, I forgot to do that in the internal repo. I'll fix it there, but please remove it from here already.
Thanks for handling this Abdul!
Minor fixes requested by Josep
@diegoossa
diegoossa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On behalf of the physics team, PhysicsSamples LGTM
1.0.0-exp.8202220b8