Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Upgrade to 050 #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinGram merged 2 commits into master from upgrade-to-050-b
Mar 24, 2022
Merged

Upgrade to 050 #206

MartinGram merged 2 commits into master from upgrade-to-050-b
Mar 24, 2022

Conversation

Copy link
Collaborator

@jvalenzu jvalenzu commented Mar 22, 2022

Modify the public sample to match internal 0.50 entities samples
Update Editor version to 2020年3月30日f1 (1fb1bf06830e)

Joe Valenzuela added 2 commits March 18, 2022 10:56
* Modify the public sample to match internal 0.50 entities samples
* Update Editor version to 2020年3月30日f1 (1fb1bf06830e)
Copy link
Collaborator Author

Creating a new pull request because apparently my first push created a protected branch that I someone do not have permission to push to.

Old PR:
#204

Copy link
Collaborator Author

@BrianWill-Unity This push has URP and AFAIK works without error. I'm not sure why you would have had to create any settings, all the relevant assets should be included.

image

Copy link
Collaborator

@BrianWill-Unity BrianWill-Unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I maybe had a global cache issue. Anyway, after a clean reset with this branch and flushing the Library, it now renders out of the box 👍 .

Copy link
Collaborator

@kjellander-unity kjellander-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I'm a useful reviewer here but this LGTM

@MartinGram MartinGram merged commit 207e3b1 into master Mar 24, 2022
@MartinGram MartinGram deleted the upgrade-to-050-b branch March 24, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjellander-unity kjellander-unity kjellander-unity approved these changes

@unitydavidlo unitydavidlo unitydavidlo approved these changes

@BrianWill-Unity BrianWill-Unity BrianWill-Unity approved these changes

@jmankinUnity jmankinUnity Awaiting requested review from jmankinUnity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /