-
Notifications
You must be signed in to change notification settings - Fork 45
Call entityManager.flush()
on every entityManager
usage and dynamically remove failing UtStatementCallModel
s
#2550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@IlyaMuravjov
IlyaMuravjov
added
ctg-enhancement
New feature, improvement or change request
comp-codegen
Issue is related to code generator
comp-instrumented-process
Issue is related to Instrumented process
comp-spring
Issue is related to Spring projects support
labels
Aug 24, 2023
utbot-framework-api/src/main/kotlin/org/utbot/framework/plugin/api/mapper/UtModelDeepMapper.kt
Show resolved
Hide resolved
utbot-framework-api/src/main/kotlin/org/utbot/framework/plugin/api/mapper/UtModelMapper.kt
Show resolved
Hide resolved
utbot-framework-api/src/main/kotlin/org/utbot/framework/plugin/api/mapper/UtModelNoopMapper.kt
Show resolved
Hide resolved
.../kotlin/org/utbot/instrumentation/instrumentation/spring/SpringUtExecutionInstrumentation.kt
Show resolved
Hide resolved
.../src/main/kotlin/org/utbot/framework/codegen/tree/CgSpringIntegrationTestClassConstructor.kt
Show resolved
Hide resolved
EgorkaKulikov
EgorkaKulikov
approved these changes
Aug 25, 2023
@EgorkaKulikov
EgorkaKulikov
deleted the
ilya_m/safe_call_models_and_flush
branch
August 25, 2023 14:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
UtStatementCallModel
s that have been observed to throw an exception fromstateBefore
then try to rerun the invocation, that process is repeated until either value construction phase succeeds or limit of 5 reruns is reached.entityManager.flush()
on everyentityManager
usage (in codegen only).ClassNotFoundException: javax.servlet.http.Cookie
when generating controller tests #2542 by reverting Add support for @CookieValue annotation #2519 .How to test
Manual tests
Failing test from issue should not generate (in the example from the issue, test that saves valid entity to the database is still minimized out due to it being possible to cover all branches of
OwnerController.findOwner()
without saving anything to the database, to get tests with actual saves to database, the lineif (owner == null) throw new NullPointerException("owner");
can be added toOwnerController.findOwner()
).Self-check list