Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Clean up OverallArchitecture, Fuzzing and Logging docs #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olganaumenko merged 2 commits into main from olganaumenko/OverAll_Fuzzing_Logging_doc_cleanup
Mar 6, 2023

Conversation

Copy link
Collaborator

@olganaumenko olganaumenko commented Feb 28, 2023 •
edited
Loading

Description

How to test

The PR introduces no code changes.
Manual scenario: the text itself has been previewed in the IntelliJ IDEA viewer.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@olganaumenko olganaumenko added ctg-documentation Improvements or additions to documentation comp-fuzzing Issue is related to the fuzzing comp-logging Issue is related to Logging priority-minor Issue is rated as minor labels Feb 28, 2023
Say, in most of the programming languages, any integer may be represented as a bit array, and the fuzzer can construct and
modify bit arrays. So, in the general case, the boundary values for the integer are these bit arrays:

* [0, 0, 0, ..., 0] — null
Copy link
Collaborator

@Markoutte Markoutte Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change the null to zero?

Copy link
Collaborator Author

@olganaumenko olganaumenko Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Fixed.

* [0, 1, 1, ..., 1] - maximum value / 2 + 1
* [0, 0, ..., 0, 1] - plus 1
* [1, 1, 1, ..., 1] - maximum value
* [0, 0, 0, ..., 0] — null (minimum value)
Copy link
Collaborator

@Markoutte Markoutte Mar 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change the null to zero?

Copy link
Collaborator

@Domonion Domonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@olganaumenko olganaumenko merged commit 1b38315 into main Mar 6, 2023
@olganaumenko olganaumenko deleted the olganaumenko/OverAll_Fuzzing_Logging_doc_cleanup branch March 6, 2023 07:47
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Markoutte Markoutte Markoutte approved these changes

@Domonion Domonion Domonion approved these changes

Assignees
No one assigned
Labels
comp-fuzzing Issue is related to the fuzzing comp-logging Issue is related to Logging ctg-documentation Improvements or additions to documentation priority-minor Issue is rated as minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /