Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

describe cache shouldn’t create all connections#49

Open
NaderCHASER wants to merge 2 commits intoUnionOfRAD:1.0 from
NaderCHASER:master
Open

describe cache shouldn’t create all connections #49
NaderCHASER wants to merge 2 commits intoUnionOfRAD:1.0 from
NaderCHASER:master

Conversation

@NaderCHASER
Copy link

@NaderCHASER NaderCHASER commented Jan 26, 2017

Resolves #48

Copy link
Member

mariuswilms commented Jan 29, 2017
edited
Loading

Thanks for providing a patch for this issue. As this tends to be more like a bugfix, can you please submit against the 1.0 branch and use long array syntax. 1.0 was still PHP <5.4.

http://li3.me/development#bugs

NaderCHASER reacted with thumbs up emoji

* Stays consistent with long array syntax used elsewhere in file / branch.
@NaderCHASER NaderCHASER changed the base branch from master to 1.0 January 30, 2017 17:16
Copy link
Member

Just had a deeper look into the issue. Wouldn't disabling autoCreate here, lead to none of the connections having schema caching enabled?

Copy link
Author

You're right. The alternative (previous) approach initiated every connection on every action, though.

I'm not sure how to tackle this yet. The problem lies within the fact that autoConnect defaults to true, leading Connections::get($name) to initiate the connection, regardless of whether or not it's being used for that action. There has to be a way to set autoConnect to false through Connections::get(). I thought it was [ 'config' => [ 'autoConnect' => false ] ] but that didn't appear to work.

Copy link
Member

Sorry for not getting back earlier. Yes, there's no obvious bug fix here, that can be applied to just this repo's code. Looks like we need to dig deeper and probably patch Connections.

NaderCHASER reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /