Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

WIP Optimize TryGetArgumentDirectionAndType#371

Open
marius-bughiu wants to merge 2 commits intodevelop from
perf/try-get-argument-direction-and-type
Open

WIP Optimize TryGetArgumentDirectionAndType #371
marius-bughiu wants to merge 2 commits intodevelop from
perf/try-get-argument-direction-and-type

Conversation

@marius-bughiu
Copy link
Contributor

@marius-bughiu marius-bughiu commented Aug 2, 2025 •
edited
Loading

It's on a hot path and having quite an impact in a test project.

image

Benchmarks (warm):

Method Mean Error StdDev Gen 0 Allocated
ArgumentGeneric 6.718 ns 0.0759 ns 0.0710 ns - -
ArgumentNonGeneric 1.799 ns 0.0167 ns 0.0139 ns - -
NonArgumentType 2.368 ns 0.0308 ns 0.0288 ns - -
ArgumentGenericOld 46.647 ns 0.1908 ns 0.1785 ns 0.0018 32 B
ArgumentNonGenericOld 3.054 ns 0.0286 ns 0.0267 ns - -
NonArgumentTypeOld 3.389 ns 0.0504 ns 0.0471 ns - -

Benchmarks (cold):

Method Mean Error StdDev Gen 0 Allocated
ArgumentGeneric 66.940 ns 0.5590 ns 0.4955 ns 0.0018 32 B
ArgumentNonGeneric 2.196 ns 0.0264 ns 0.0247 ns - -
NonArgumentType 2.681 ns 0.0470 ns 0.0440 ns - -
ArgumentGenericOld 46.857 ns 0.2948 ns 0.2758 ns 0.0018 32 B
ArgumentNonGenericOld 2.868 ns 0.0575 ns 0.0480 ns - -
NonArgumentTypeOld 3.256 ns 0.0414 ns 0.0367 ns - -

seer-by-sentry[bot] reacted with hooray emoji
@marius-bughiu marius-bughiu force-pushed the perf/try-get-argument-direction-and-type branch from bb4f621 to 6da8912 Compare August 4, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aoltean16 aoltean16 Awaiting requested review from aoltean16 aoltean16 is a code owner

@gabriela-lungu-uip gabriela-lungu-uip Awaiting requested review from gabriela-lungu-uip

At least 1 approving review is required to merge this pull request.

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /