-
Notifications
You must be signed in to change notification settings - Fork 231
Expose UnaryExpressionHelpers and BinaryExpressionHelpers#290
Expose UnaryExpressionHelpers and BinaryExpressionHelpers #290TheBrambleShark wants to merge 2 commits intoUiPath:develop from
Conversation
@aoltean16
aoltean16
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increment and Decrement do seem like a good idea, but the other two can be incorporated in the fist 2, if you add increment / decrement step value as another parameter, with default of 1
TheBrambleShark
commented
Jan 30, 2024
This is true, but number = number + 1 feels a bit awkward especially when we have support in the language for other operators.
Additionally, exposing these types as suggested will allow third party developers to contribute additional operators in the future. For example, I like working with nullable enabled, so having nullableValue ??= foo wrapped as an activity would be extremely valuable. Currently I have to do this as an if not null then assign, which doubles the amount of work I have to do for what should be a simple operation.
The IDE should make development easier, not harder.
Uh oh!
There was an error while loading. Please reload this page.
Also promotes my Increment/Decrement and AddAssign/SubtractAssign expressions.
My added expressions are fully documented and ready for NET7. IfDefs can be removed if this is not desired.
Code also assumes a nullable context. I invite discussion on whether to remove nullable annotations or whether to enable nullable. I personally find it is more clear to the developer but this can be removed if requested.
All of these expressions expect numeric types (with appropriate constraints in Net7). In net6, theoretically any type would be allowed, but non-numeric types will throw. This is by design. The expressions simply provide activities for common C# operations.
Increment=number++Decrement=number--AddAssign=number += otherNumberSubtractAssign=number -= otherNumberIf anyone knows how to add the designer files for these activities, please do let me know. I have been unable to figure out how to do this in Net6 and newer as PresentationCore does not seem to have been ported.
Edit: Fixes #288