-
-
Notifications
You must be signed in to change notification settings - Fork 25
chore(deps): update test & linting packages (major) #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,11 +21,11 @@ | |
| ], | ||
| "devDependencies": { | ||
| "@sinonjs/fake-timers": "15.1.0", | ||
| "c8": "8.0.1", | ||
| "c8": "10.1.3", | ||
| "date-fns": "2.30.0", | ||
| "delay": "5.0.0", | ||
| "mocha": "11.7.5", | ||
| "rewire": "7.0.0", | ||
| "rewire": "9.0.1", | ||
|
Comment on lines
+24
to
+28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash # Check for Node.js version requirements in the repository # Look for engines field in root package.json echo "=== Root package.json engines field ===" cat package.json 2>/dev/null | jq '.engines' || echo "No root package.json or no engines field" # Check this package's engines field echo -e "\n=== job-manager package.json engines field ===" cat packages/job-manager/package.json | jq '.engines' # Look for .nvmrc or .node-version files echo -e "\n=== Node version files ===" if fd -t f -name '.nvmrc' -o -name '.node-version' 2>/dev/null; then fd -t f -name '.nvmrc' -o -name '.node-version' -exec cat {} \; else echo "No .nvmrc or .node-version files found" fi # Also check for package.json engines in job-manager echo -e "\n=== Full job-manager package.json engines context ===" jq '.engines' packages/job-manager/package.json 2>/dev/null || echo "No engines field in job-manager package.json" # Check if there are any CI configuration files that specify Node version echo -e "\n=== CI Configuration files ===" find . -maxdepth 2 -type f \( -name '.github' -o -name '.gitlab-ci.yml' -o -name '.travis.yml' -o -name 'Makefile' \) 2>/dev/null | head -5 Repository: TryGhost/framework Length of output: 318 🏁 Script executed: #!/bin/bash # Search for GitHub Actions workflows echo "=== GitHub Actions workflows ===" find . -path './.github/workflows/*.yml' -o -path './.github/workflows/*.yaml' 2>/dev/null | head -20 # If workflows exist, show their content echo -e "\n=== Workflow files content (first 100 lines) ===" find . -type f -path '*/.github/workflows/*' -name '*.yml' -o -name '*.yaml' 2>/dev/null | head -3 | xargs -I {} sh -c 'echo "File: {}"; head -100 "{}"' # Check README for Node.js version info echo -e "\n=== README.md Node.js version mention ===" rg -i "node.*version|minimum.*node|node.*18|node.*16|node.*14" README.md 2>/dev/null || echo "No mentions found" # Check for any .github directory structure echo -e "\n=== .github directory contents ===" ls -la .github/ 2>/dev/null | head -20 # Check rewire v9 requirements echo -e "\n=== Checking rewire changelog/requirements ===" jq '.devDependencies.rewire' packages/job-manager/package.json Repository: TryGhost/framework Length of output: 759 🌐 Web query:
💡 Result:
Source: [1] 🌐 Web query:
💡 Result:
ESLint v9 requires Node.js Sources: [1] [2] Node.js 18+ is required for these major dependency updates. Both
🤖 Prompt for AI Agents |
||
| "should": "13.2.3", | ||
| "sinon": "21.0.1" | ||
| }, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,7 @@ | |
| "lib" | ||
| ], | ||
| "devDependencies": { | ||
| "c8": "8.0.1", | ||
| "c8": "10.1.3", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash # Check Node version declarations and CI matrices echo "=== Checking for Node version files ===" fd -a -H -g '.nvmrc' -g '.node-version' -g '.tool-versions' 2>/dev/null || echo "No .nvmrc/.node-version/.tool-versions found" echo -e "\n=== Checking CI workflows for node-version ===" fd -a -H '.github/workflows/*.yml' -o '.github/workflows/*.yaml' 2>/dev/null | head -20 | while read f; do echo "File: $f" rg -n 'node-version|NODE_VERSION' "$f" 2>/dev/null || true done echo -e "\n=== Checking package.json files for engines.node ===" fd -a 'package.json' --exec rg -l '"engines"' {} \; 2>/dev/null | head -10 | while read f; do echo "File: $f" rg -A 2 '"engines"\s*:\s*{' "$f" 2>/dev/null || true done Repository: TryGhost/framework Length of output: 324 🏁 Script executed: #!/bin/bash echo "=== Listing .github/workflows directory ===" find .github/workflows -type f 2>/dev/null | head -20 echo -e "\n=== Node version in root package.json ===" cat package.json | rg -A 5 '"engines"' 2>/dev/null || echo "No engines field" echo -e "\n=== Node version in packages/security/package.json ===" cat packages/security/package.json | rg -A 5 '"engines"' 2>/dev/null || echo "No engines field" echo -e "\n=== Searching all workflow files for node-version ===" find .github/workflows -type f -name '*.yml' -o -name '*.yaml' 2>/dev/null | while read f; do echo "--- File: $f ---" rg 'node-version|node_version' "$f" 2>/dev/null | head -10 || true done echo -e "\n=== Searching all workflow files for Node setup ===" find .github/workflows -type f \( -name '*.yml' -o -name '*.yaml' \) 2>/dev/null | while read f; do echo "--- File: $f ---" rg -A 2 'uses.*setup-node|uses.*node' "$f" 2>/dev/null | head -10 || true done Repository: TryGhost/framework Length of output: 455 🏁 Script executed: #!/bin/bash echo "=== Content of .github/workflows/test.yml ===" cat .github/workflows/test.yml echo -e "\n\n=== Content of packages/security/package.json ===" cat packages/security/package.json Repository: TryGhost/framework Length of output: 1364 🏁 Script executed: #!/bin/bash echo "=== Content of root package.json ===" cat package.json echo -e "\n=== Checking for any .npmrc or other config files ===" ls -la | grep -E 'npmrc|nvmrc|node-version' Repository: TryGhost/framework Length of output: 868 🌐 Web query:
💡 Result: For c8 v10.x, the minimum required Node.js version is For reference: c8 v9.0.0 raised the minimum to Node Sources: [1], [2] Add Node.js version constraint to packages/security/package.json. c8 v10.1.3 requires Node >=18. The "engines": { "node": ">=18.0.0" } Also verify that the inherited CI workflow in 🤖 Prompt for AI Agents |
||
| "mocha": "11.7.5", | ||
| "should": "13.2.3", | ||
| "sinon": "21.0.1", | ||
|
|
||