Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(deps): update test & linting packages (major) #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into main
base: main
Choose a base branch
Loading
from renovate/major-test-and-linting-packages
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/api-framework/package.json
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"lib"
],
"devDependencies": {
"c8": "8.0.1",
"c8": "10.1.3",
"mocha": "11.7.5",
"should": "13.2.3",
"sinon": "21.0.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/bookshelf-pagination/package.json
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
},
"devDependencies": {
"mocha": "11.7.5",
"rewire": "7.0.0",
"rewire": "9.0.1",
"should": "13.2.3",
"sinon": "21.0.1"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/domain-events/package.json
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
],
"devDependencies": {
"@tryghost/logging": "^2.5.0",
"c8": "8.0.1",
"c8": "10.1.3",
"mocha": "11.7.5",
"should": "13.2.3"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/job-manager/package.json
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
],
"devDependencies": {
"@sinonjs/fake-timers": "15.1.0",
"c8": "8.0.1",
"c8": "10.1.3",
"date-fns": "2.30.0",
"delay": "5.0.0",
"mocha": "11.7.5",
"rewire": "7.0.0",
"rewire": "9.0.1",
Comment on lines +24 to +28
Copy link

@coderabbitai coderabbitai bot Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check for Node.js version requirements in the repository
# Look for engines field in root package.json
echo "=== Root package.json engines field ==="
cat package.json 2>/dev/null | jq '.engines' || echo "No root package.json or no engines field"
# Check this package's engines field
echo -e "\n=== job-manager package.json engines field ==="
cat packages/job-manager/package.json | jq '.engines'
# Look for .nvmrc or .node-version files
echo -e "\n=== Node version files ==="
if fd -t f -name '.nvmrc' -o -name '.node-version' 2>/dev/null; then
 fd -t f -name '.nvmrc' -o -name '.node-version' -exec cat {} \;
else
 echo "No .nvmrc or .node-version files found"
fi
# Also check for package.json engines in job-manager
echo -e "\n=== Full job-manager package.json engines context ==="
jq '.engines' packages/job-manager/package.json 2>/dev/null || echo "No engines field in job-manager package.json"
# Check if there are any CI configuration files that specify Node version
echo -e "\n=== CI Configuration files ==="
find . -maxdepth 2 -type f \( -name '.github' -o -name '.gitlab-ci.yml' -o -name '.travis.yml' -o -name 'Makefile' \) 2>/dev/null | head -5

Repository: TryGhost/framework

Length of output: 318


🏁 Script executed:

#!/bin/bash
# Search for GitHub Actions workflows
echo "=== GitHub Actions workflows ==="
find . -path './.github/workflows/*.yml' -o -path './.github/workflows/*.yaml' 2>/dev/null | head -20
# If workflows exist, show their content
echo -e "\n=== Workflow files content (first 100 lines) ==="
find . -type f -path '*/.github/workflows/*' -name '*.yml' -o -name '*.yaml' 2>/dev/null | head -3 | xargs -I {} sh -c 'echo "File: {}"; head -100 "{}"'
# Check README for Node.js version info
echo -e "\n=== README.md Node.js version mention ==="
rg -i "node.*version|minimum.*node|node.*18|node.*16|node.*14" README.md 2>/dev/null || echo "No mentions found"
# Check for any .github directory structure
echo -e "\n=== .github directory contents ==="
ls -la .github/ 2>/dev/null | head -20
# Check rewire v9 requirements
echo -e "\n=== Checking rewire changelog/requirements ==="
jq '.devDependencies.rewire' packages/job-manager/package.json

Repository: TryGhost/framework

Length of output: 759


🌐 Web query:

c8 v10 Node.js version requirements minimum

💡 Result:

c8 v10 requires Node.js >= 18 (per the package’s engines.node field). [1]

Source: [1]


🌐 Web query:

rewire v9 Node.js minimum version requirements

💡 Result:

rewire v9.x does not declare a package.json engines.node minimum, but it has a runtime dependency on eslint ^9.x ("eslint": "^9.30"). [1]

ESLint v9 requires Node.js ^18.18.0 || ^20.9.0 || >=21.1.0, so in practice the minimum Node.js version you should use with rewire v9 is 18.18.0 (or 20.9.0+, or 21.1.0+). [2]

Sources: [1] [2]


Node.js 18+ is required for these major dependency updates.

Both c8 v10 (requires Node.js >= 18) and rewire v9 (requires Node.js >= 18.18.0 due to ESLint 9 dependency) mandate Node.js 18 or higher. The repository currently has no engines field in package.json to enforce this minimum version. Verify that:

  • The CI environment (external tryghost/actions workflow) runs Node.js 18+
  • All team members use Node.js 18+ locally
  • Consider adding "engines": { "node": ">=18" } to package.json to prevent incompatible usage
🤖 Prompt for AI Agents
In `@packages/job-manager/package.json` around lines 24 - 28, The package.json
currently upgrades c8 and rewire which require Node.js 18+, so add an "engines"
entry to the package.json to declare the minimum Node version (e.g., "node":
">=18") to prevent installs with older runtimes; update the package.json near
the dependency list (references: the c8 and rewire dependency entries) and
ensure CI/workflow and developer docs reflect Node >=18 so the tryghost/actions
CI and local dev environments use the required Node version.

"should": "13.2.3",
"sinon": "21.0.1"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/metrics/package.json
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"devDependencies": {
"c8": "10.1.3",
"mocha": "11.7.5",
"rewire": "7.0.0",
"rewire": "9.0.1",
"should": "13.2.3",
"sinon": "21.0.1"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/mw-error-handler/package.json
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"lib"
],
"devDependencies": {
"c8": "8.0.1",
"c8": "10.1.3",
"mocha": "11.7.5",
"sinon": "21.0.1"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/mw-vhost/package.json
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
"lib"
],
"devDependencies": {
"c8": "8.0.1",
"c8": "10.1.3",
"mocha": "11.7.5",
"supertest": "6.3.4"
"supertest": "7.2.2"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/prometheus-metrics/package.json
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"c8": "10.1.3",
"knex": "2.4.2",
"mocha": "11.7.5",
"nock": "13.5.6",
"nock": "14.0.10",
"sinon": "21.0.1",
"supertest": "7.2.2",
"ts-node": "10.9.2",
Expand Down
4 changes: 2 additions & 2 deletions packages/request/package.json
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
"devDependencies": {
"c8": "10.1.3",
"mocha": "11.7.5",
"nock": "13.5.6",
"rewire": "7.0.0",
"nock": "14.0.10",
"rewire": "9.0.1",
"should": "13.2.3",
"sinon": "21.0.1"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/security/package.json
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"lib"
],
"devDependencies": {
"c8": "8.0.1",
"c8": "10.1.3",
Copy link

@coderabbitai coderabbitai bot Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check Node version declarations and CI matrices
echo "=== Checking for Node version files ==="
fd -a -H -g '.nvmrc' -g '.node-version' -g '.tool-versions' 2>/dev/null || echo "No .nvmrc/.node-version/.tool-versions found"
echo -e "\n=== Checking CI workflows for node-version ==="
fd -a -H '.github/workflows/*.yml' -o '.github/workflows/*.yaml' 2>/dev/null | head -20 | while read f; do
 echo "File: $f"
 rg -n 'node-version|NODE_VERSION' "$f" 2>/dev/null || true
done
echo -e "\n=== Checking package.json files for engines.node ==="
fd -a 'package.json' --exec rg -l '"engines"' {} \; 2>/dev/null | head -10 | while read f; do
 echo "File: $f"
 rg -A 2 '"engines"\s*:\s*{' "$f" 2>/dev/null || true
done

Repository: TryGhost/framework

Length of output: 324


🏁 Script executed:

#!/bin/bash
echo "=== Listing .github/workflows directory ==="
find .github/workflows -type f 2>/dev/null | head -20
echo -e "\n=== Node version in root package.json ==="
cat package.json | rg -A 5 '"engines"' 2>/dev/null || echo "No engines field"
echo -e "\n=== Node version in packages/security/package.json ==="
cat packages/security/package.json | rg -A 5 '"engines"' 2>/dev/null || echo "No engines field"
echo -e "\n=== Searching all workflow files for node-version ==="
find .github/workflows -type f -name '*.yml' -o -name '*.yaml' 2>/dev/null | while read f; do
 echo "--- File: $f ---"
 rg 'node-version|node_version' "$f" 2>/dev/null | head -10 || true
done
echo -e "\n=== Searching all workflow files for Node setup ==="
find .github/workflows -type f \( -name '*.yml' -o -name '*.yaml' \) 2>/dev/null | while read f; do
 echo "--- File: $f ---"
 rg -A 2 'uses.*setup-node|uses.*node' "$f" 2>/dev/null | head -10 || true
done

Repository: TryGhost/framework

Length of output: 455


🏁 Script executed:

#!/bin/bash
echo "=== Content of .github/workflows/test.yml ==="
cat .github/workflows/test.yml
echo -e "\n\n=== Content of packages/security/package.json ==="
cat packages/security/package.json

Repository: TryGhost/framework

Length of output: 1364


🏁 Script executed:

#!/bin/bash
echo "=== Content of root package.json ==="
cat package.json
echo -e "\n=== Checking for any .npmrc or other config files ==="
ls -la | grep -E 'npmrc|nvmrc|node-version'

Repository: TryGhost/framework

Length of output: 868


🌐 Web query:

c8 v10 Node.js minimum version requirement

💡 Result:

For c8 v10.x, the minimum required Node.js version is >=18 (per the engines.node field in c8’s v10 package metadata). [1]

For reference: c8 v9.0.0 raised the minimum to Node >=14.14.0. [2]

Sources: [1], [2]


Add Node.js version constraint to packages/security/package.json.

c8 v10.1.3 requires Node >=18. The packages/security/package.json currently lacks an engines.node field declaring this constraint. Add it to prevent installation on incompatible Node versions:

"engines": {
 "node": ">=18.0.0"
}

Also verify that the inherited CI workflow in tryghost/actions is configured to test against Node 18+.

🤖 Prompt for AI Agents
In `@packages/security/package.json` at line 28, The package.json in
packages/security lists "c8": "10.1.3" which requires Node >=18, so add an
"engines": { "node": ">=18.0.0" } entry to packages/security/package.json to
declare the Node version constraint; then verify the inherited CI configuration
in tryghost/actions is set to run tests on Node 18+ (update the workflow matrix
if necessary) so installs and CI will fail-fast on incompatible Node versions.

"mocha": "11.7.5",
"should": "13.2.3",
"sinon": "21.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/version/package.json
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"devDependencies": {
"c8": "10.1.3",
"mocha": "11.7.5",
"rewire": "7.0.0",
"rewire": "9.0.1",
"should": "13.2.3",
"sinon": "21.0.1"
},
Expand Down
Loading
Loading

AltStyle によって変換されたページ (->オリジナル) /