-
-
Notifications
You must be signed in to change notification settings - Fork 25
chore(deps): update test & linting packages (major) #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Branch automerge failure
This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.
- Branch has one or more failed status checks
4730778 to
4163fec
Compare
26ca341 to
c1aacb7
Compare
fe869e1 to
8d66dee
Compare
73e1f20 to
a7655c6
Compare
6c04434 to
09de975
Compare
cbe3cba to
6a121a1
Compare
19cf35d to
5469eb8
Compare
9434fe2 to
96af252
Compare
8a934a6 to
e23127a
Compare
d3f8b28 to
4eb7831
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/security/package.json`:
- Line 28: The package.json in packages/security lists "c8": "10.1.3" which
requires Node >=18, so add an "engines": { "node": ">=18.0.0" } entry to
packages/security/package.json to declare the Node version constraint; then
verify the inherited CI configuration in tryghost/actions is set to run tests on
Node 18+ (update the workflow matrix if necessary) so installs and CI will
fail-fast on incompatible Node versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash # Check Node version declarations and CI matrices echo "=== Checking for Node version files ===" fd -a -H -g '.nvmrc' -g '.node-version' -g '.tool-versions' 2>/dev/null || echo "No .nvmrc/.node-version/.tool-versions found" echo -e "\n=== Checking CI workflows for node-version ===" fd -a -H '.github/workflows/*.yml' -o '.github/workflows/*.yaml' 2>/dev/null | head -20 | while read f; do echo "File: $f" rg -n 'node-version|NODE_VERSION' "$f" 2>/dev/null || true done echo -e "\n=== Checking package.json files for engines.node ===" fd -a 'package.json' --exec rg -l '"engines"' {} \; 2>/dev/null | head -10 | while read f; do echo "File: $f" rg -A 2 '"engines"\s*:\s*{' "$f" 2>/dev/null || true done
Repository: TryGhost/framework
Length of output: 324
🏁 Script executed:
#!/bin/bash echo "=== Listing .github/workflows directory ===" find .github/workflows -type f 2>/dev/null | head -20 echo -e "\n=== Node version in root package.json ===" cat package.json | rg -A 5 '"engines"' 2>/dev/null || echo "No engines field" echo -e "\n=== Node version in packages/security/package.json ===" cat packages/security/package.json | rg -A 5 '"engines"' 2>/dev/null || echo "No engines field" echo -e "\n=== Searching all workflow files for node-version ===" find .github/workflows -type f -name '*.yml' -o -name '*.yaml' 2>/dev/null | while read f; do echo "--- File: $f ---" rg 'node-version|node_version' "$f" 2>/dev/null | head -10 || true done echo -e "\n=== Searching all workflow files for Node setup ===" find .github/workflows -type f \( -name '*.yml' -o -name '*.yaml' \) 2>/dev/null | while read f; do echo "--- File: $f ---" rg -A 2 'uses.*setup-node|uses.*node' "$f" 2>/dev/null | head -10 || true done
Repository: TryGhost/framework
Length of output: 455
🏁 Script executed:
#!/bin/bash echo "=== Content of .github/workflows/test.yml ===" cat .github/workflows/test.yml echo -e "\n\n=== Content of packages/security/package.json ===" cat packages/security/package.json
Repository: TryGhost/framework
Length of output: 1364
🏁 Script executed:
#!/bin/bash echo "=== Content of root package.json ===" cat package.json echo -e "\n=== Checking for any .npmrc or other config files ===" ls -la | grep -E 'npmrc|nvmrc|node-version'
Repository: TryGhost/framework
Length of output: 868
🌐 Web query:
c8 v10 Node.js minimum version requirement
💡 Result:
For c8 v10.x, the minimum required Node.js version is >=18 (per the engines.node field in c8’s v10 package metadata). [1]
For reference: c8 v9.0.0 raised the minimum to Node >=14.14.0. [2]
Sources: [1], [2]
Add Node.js version constraint to packages/security/package.json.
c8 v10.1.3 requires Node >=18. The packages/security/package.json currently lacks an engines.node field declaring this constraint. Add it to prevent installation on incompatible Node versions:
"engines": { "node": ">=18.0.0" }
Also verify that the inherited CI workflow in tryghost/actions is configured to test against Node 18+.
🤖 Prompt for AI Agents
In `@packages/security/package.json` at line 28, The package.json in
packages/security lists "c8": "10.1.3" which requires Node >=18, so add an
"engines": { "node": ">=18.0.0" } entry to packages/security/package.json to
declare the Node version constraint; then verify the inherited CI configuration
in tryghost/actions is set to run tests on Node 18+ (update the workflow matrix
if necessary) so installs and CI will fail-fast on incompatible Node versions.
79349dd to
ef562db
Compare
01fed80 to
5343b9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/job-manager/package.json`:
- Around line 24-28: The package.json currently upgrades c8 and rewire which
require Node.js 18+, so add an "engines" entry to the package.json to declare
the minimum Node version (e.g., "node": ">=18") to prevent installs with older
runtimes; update the package.json near the dependency list (references: the c8
and rewire dependency entries) and ensure CI/workflow and developer docs reflect
Node >=18 so the tryghost/actions CI and local dev environments use the required
Node version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash # Check for Node.js version requirements in the repository # Look for engines field in root package.json echo "=== Root package.json engines field ===" cat package.json 2>/dev/null | jq '.engines' || echo "No root package.json or no engines field" # Check this package's engines field echo -e "\n=== job-manager package.json engines field ===" cat packages/job-manager/package.json | jq '.engines' # Look for .nvmrc or .node-version files echo -e "\n=== Node version files ===" if fd -t f -name '.nvmrc' -o -name '.node-version' 2>/dev/null; then fd -t f -name '.nvmrc' -o -name '.node-version' -exec cat {} \; else echo "No .nvmrc or .node-version files found" fi # Also check for package.json engines in job-manager echo -e "\n=== Full job-manager package.json engines context ===" jq '.engines' packages/job-manager/package.json 2>/dev/null || echo "No engines field in job-manager package.json" # Check if there are any CI configuration files that specify Node version echo -e "\n=== CI Configuration files ===" find . -maxdepth 2 -type f \( -name '.github' -o -name '.gitlab-ci.yml' -o -name '.travis.yml' -o -name 'Makefile' \) 2>/dev/null | head -5
Repository: TryGhost/framework
Length of output: 318
🏁 Script executed:
#!/bin/bash # Search for GitHub Actions workflows echo "=== GitHub Actions workflows ===" find . -path './.github/workflows/*.yml' -o -path './.github/workflows/*.yaml' 2>/dev/null | head -20 # If workflows exist, show their content echo -e "\n=== Workflow files content (first 100 lines) ===" find . -type f -path '*/.github/workflows/*' -name '*.yml' -o -name '*.yaml' 2>/dev/null | head -3 | xargs -I {} sh -c 'echo "File: {}"; head -100 "{}"' # Check README for Node.js version info echo -e "\n=== README.md Node.js version mention ===" rg -i "node.*version|minimum.*node|node.*18|node.*16|node.*14" README.md 2>/dev/null || echo "No mentions found" # Check for any .github directory structure echo -e "\n=== .github directory contents ===" ls -la .github/ 2>/dev/null | head -20 # Check rewire v9 requirements echo -e "\n=== Checking rewire changelog/requirements ===" jq '.devDependencies.rewire' packages/job-manager/package.json
Repository: TryGhost/framework
Length of output: 759
🌐 Web query:
c8 v10 Node.js version requirements minimum
💡 Result:
c8 v10 requires Node.js >= 18 (per the package’s engines.node field). [1]
Source: [1]
🌐 Web query:
rewire v9 Node.js minimum version requirements
💡 Result:
rewire v9.x does not declare a package.json engines.node minimum, but it has a runtime dependency on eslint ^9.x ("eslint": "^9.30"). [1]
ESLint v9 requires Node.js ^18.18.0 || ^20.9.0 || >=21.1.0, so in practice the minimum Node.js version you should use with rewire v9 is 18.18.0 (or 20.9.0+, or 21.1.0+). [2]
Sources: [1] [2]
Node.js 18+ is required for these major dependency updates.
Both c8 v10 (requires Node.js >= 18) and rewire v9 (requires Node.js >= 18.18.0 due to ESLint 9 dependency) mandate Node.js 18 or higher. The repository currently has no engines field in package.json to enforce this minimum version. Verify that:
- The CI environment (external
tryghost/actionsworkflow) runs Node.js 18+ - All team members use Node.js 18+ locally
- Consider adding
"engines": { "node": ">=18" }topackage.jsonto prevent incompatible usage
🤖 Prompt for AI Agents
In `@packages/job-manager/package.json` around lines 24 - 28, The package.json
currently upgrades c8 and rewire which require Node.js 18+, so add an "engines"
entry to the package.json to declare the minimum Node version (e.g., "node":
">=18") to prevent installs with older runtimes; update the package.json near
the dependency list (references: the c8 and rewire dependency entries) and
ensure CI/workflow and developer docs reflect Node >=18 so the tryghost/actions
CI and local dev environments use the required Node version.
5343b9c to
b03bbf2
Compare
b03bbf2 to
23cc361
Compare
Uh oh!
There was an error while loading. Please reload this page.
This PR contains the following updates:
8.0.1→10.1.313.5.6→14.0.107.0.0→9.0.16.3.4→7.2.2Release Notes
bcoe/c8 (c8)
v10.1.3Compare Source
Bug Fixes
v10.1.2Compare Source
Bug Fixes
v10.1.1Compare Source
Bug Fixes
v10.1.0Compare Source
Features
v10.0.0Compare Source
⚠ BREAKING CHANGES
Bug Fixes
v9.1.0Compare Source
Features
Bug Fixes
v9.0.0Compare Source
⚠ BREAKING CHANGES
Features
nock/nock (nock)
v14.0.10Compare Source
Bug Fixes
v14.0.9Compare Source
Bug Fixes
v14.0.8Compare Source
Bug Fixes
v14.0.7Compare Source
Bug Fixes
v14.0.6Compare Source
Bug Fixes
v14.0.5Compare Source
Bug Fixes
v14.0.4Compare Source
Bug Fixes
v14.0.3Compare Source
Bug Fixes
v14.0.2Compare Source
Bug Fixes
v14.0.1Compare Source
Bug Fixes
v14.0.0Compare Source
BREAKING CHANGES
Features
fetch(#2813) (ef3f158)jhnns/rewire (rewire)
v9.0.1Compare Source
v9.0.0Compare Source
v8.0.0Compare Source
ladjs/supertest (supertest)
v7.2.2Compare Source
1954bcfv7.2.1Compare Source
d4f04fbv7.2.0Compare Source
c4b08a6d084ce261f3ddfbd2fe4507bf4fb0666797953eca781ab94c14d905df508b304f896801e642b0v7.1.4Compare Source
6021ec8ceca508b1fb983v7.1.3Compare Source
b6fd28175bcbc9v7.1.2Compare Source
6d060e30413057e2be0e1b7f985b411f7cev7.1.1Compare Source
f553845d37d197v7.1.0Compare Source
de045d4be0d5c735ac86fe67fcb296c06e392079a0v7.0.0Compare Source
225118cf2904311e18c20Configuration
📅 Schedule: Branch creation - Monday through Friday ( * * * * 1-5 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.