-
-
Notifications
You must be signed in to change notification settings - Fork 256
Open
Conversation
lilhoser
marked this pull request as ready for review
August 10, 2026 17:19
taclane
commented
Aug 10, 2026
Contributor
As an alternative, would this be better addressed by some kind of "controlExplicit": true setting, and only ever let-t-r use the listed frequencies in the config?
This would address a secondary issue (t-r will absorb any control channels it learns from system update messages, which may not be desirable sometimes), and minimize the need for an affinity setting where it latches onto the first device by just letting the user have full control of where it attempts to tune.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in per-system
sourceAffinitysetting for trunked systems. When enabled, Trunk Recorder keeps that system's control-channel decoder on its startup-assigned source: same-source control-channel retunes continue normally, while an alternate outside the assigned source is skipped with a warning.The setting defaults to
false, so existing cross-source scanning behavior remains unchanged. Voice-recorder source selection is not affected.Why
Moving a control-channel decoder between sources requires disconnecting and rebuilding that decoder within the shared GNU Radio top block. In a multi-system field deployment, repeated cross-source rebuilds from one marginal system correlated with resets and brief decode interruptions on another stable system, and one rebuild stalled in the graph restart path. Operators who intentionally place every valid control channel for a site within one source need a way to prevent an unusable out-of-range candidate from causing those shared-graph rebuilds.
This is an opt-in safety boundary, not a replacement for cross-source scanning. It must only be enabled when the assigned source covers every control channel the system may use.
Changes
sourceAffinitysystem setting.Validation
ctest --output-on-failure: 1/1 passed.Closes #1156