-
Notifications
You must be signed in to change notification settings - Fork 500
Open
Conversation
Clashes with default UIWebView's callback names
nudge
commented
Nov 21, 2014
+1, would love for this to be merged!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know there's already another pull request for adding a webview delegate, though this one is a little nicer.
The callbacks are now all optional, and I've also changed the delegate names so they don't conflict with the real webview callbacks (and thereby don't override them like the other pull request).
Oh, and I've also created a nice accessor to set the delegate on the modal webview, which will set the delegate on the base webview.