-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
manual trigger
Added MYSQL_ROOT_PASSWORD: root → required. Pinned to mariadb:10.5 instead of :latest → avoids breaking changes. Improved --health-cmd with credentials → mysqladmin ping -h 127.0.0.1 -uroot -proot. Added an explicit wait-for-DB step before tests.
TooAngel
commented
Sep 6, 2025
This pull request will be automatically merged by worlddriven in 10 day(s).
The start date is based on the latest Commit date / Pull Request created date / (force) Push date.
The time to merge is 10 days.
Check the worlddriven status check or the dashboard for actual stats.
To speed up or delay the merge review the pull request:
- Speed up: Approve
- Delay or stop: Request changes
1 similar comment
TooAngel
commented
Sep 6, 2025
This pull request will be automatically merged by worlddriven in 10 day(s).
The start date is based on the latest Commit date / Pull Request created date / (force) Push date.
The time to merge is 10 days.
Check the worlddriven status check or the dashboard for actual stats.
To speed up or delay the merge review the pull request:
- Speed up: Approve
- Delay or stop: Request changes
TooAngel
commented
Sep 7, 2025
Thank you for the Pull Request, Just one thing, there is currently one Pull Request #265 which migrates the application to mongodb, I guess it will be merged tomorrow, so before this one. I think the github actions workflow should already reflect that.
aravindan888
commented
Sep 7, 2025
I’ll update this workflow to use MongoDB instead of MariaDB so it aligns with the changes from PR #265
Changed the CI workflow from MariaDB to MongoDB, using MONGO_URL with the worlddriven_test database to match the migration in PR TooAngel#265
TooAngel
commented
Sep 7, 2025
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 10 day(s).
Check the worlddriven status check or the dashboard for actual stats.
1 similar comment
TooAngel
commented
Sep 7, 2025
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 10 day(s).
Check the worlddriven status check or the dashboard for actual stats.
aravindan888
commented
Sep 7, 2025
I’ve updated the CI workflow to switch from MariaDB to MongoDB, using MONGO_URL with the worlddriven_test database as introduced in PR #265 and will almost certainly work with the migrated setup
TooAngel
commented
Sep 7, 2025
I’ve updated the CI workflow to switch from MariaDB to MongoDB, using MONGO_URL with the worlddriven_test database as introduced in PR #265 and will almost certainly work with the migrated setup
Cool, let's wait until the other PR gets merged, then we can check and I'll approve.
TooAngel
commented
Sep 8, 2025
So, the other PRs are merged now, it would be cool if you could rebase your changes on top of them so that we make sure this also works with the latest changes.
Also please squash your commits to a single one. The time to merge for world driven is based on the number of commits and I think the complexity of the solution does not necessary require multiple commits. :-)
TooAngel
commented
Sep 9, 2025
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 10 day(s).
Check the worlddriven status check or the dashboard for actual stats.
1 similar comment
TooAngel
commented
Sep 9, 2025
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 10 day(s).
Check the worlddriven status check or the dashboard for actual stats.
aravindan888
commented
Sep 9, 2025
Checking formatting...
[warn] .github/workflows/ci.yml
[warn] .github/workflows/deploy.yml
[warn] Code style issues found in 2 files. Run Prettier with --write to fix.
Error: Process completed with exit code 1.
can you check on the Prettier extension/bot (error in ci yaml)
TooAngel
commented
Sep 9, 2025
Checking formatting... [warn] .github/workflows/ci.yml [warn] .github/workflows/deploy.yml [warn] Code style issues found in 2 files. Run Prettier with --write to fix. Error: Process completed with exit code 1.
can you check on the Prettier extension/bot (error in ci yaml)
Well you can just run prettier --write . and it will automatically fix the issue. But these are only warning and status check is not yet enforced.
But please squash your commits, so make sure that the PR has only one commit. e.g. look at https://www.git-tower.com/learn/git/faq/git-squash
prettier script
TooAngel
commented
Sep 10, 2025
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 10 day(s).
Check the worlddriven status check or the dashboard for actual stats.
1 similar comment
TooAngel
commented
Sep 10, 2025
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 10 day(s).
Check the worlddriven status check or the dashboard for actual stats.
TooAngel
commented
Sep 10, 2025
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 10 day(s).
Check the worlddriven status check or the dashboard for actual stats.
1 similar comment
TooAngel
commented
Sep 10, 2025
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 10 day(s).
Check the worlddriven status check or the dashboard for actual stats.
TooAngel
commented
Sep 10, 2025
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 10 day(s).
Check the worlddriven status check or the dashboard for actual stats.
1 similar comment
TooAngel
commented
Sep 10, 2025
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 10 day(s).
Check the worlddriven status check or the dashboard for actual stats.
TooAngel
commented
Sep 10, 2025
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 10 day(s).
Check the worlddriven status check or the dashboard for actual stats.
TooAngel
commented
Sep 10, 2025
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 10 day(s).
Check the worlddriven status check or the dashboard for actual stats.
TooAngel
commented
Sep 10, 2025
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 10 day(s).
Check the worlddriven status check or the dashboard for actual stats.
1 similar comment
TooAngel
commented
Sep 10, 2025
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 10 day(s).
Check the worlddriven status check or the dashboard for actual stats.
TooAngel
commented
Sep 24, 2025
Hey, still interested to provide this, I think it would be nice.
Uh oh!
There was an error while loading. Please reload this page.
#281 CI workflow from CircleCI to GitHub Actions. The new ci.yml runs on PRs, pushes to master, and manual dispatch, and includes a MariaDB service with health checks to support testing. It sets up Node.js v20, installs dependencies, runs tests, and builds the project. With this change, CI/CD is now fully GitHub-native, and we can remove the CircleCI config and update README badges once stable.