Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Feature/apriori association rules #12956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simoderyouch wants to merge 7 commits into TheAlgorithms:master
base: master
Choose a base branch
Loading
from simoderyouch:feature/apriori-association-rules

Conversation

Copy link

@simoderyouch simoderyouch commented Sep 6, 2025

...lift)

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

This pull request adds a Custom Apriori algorithm implementation that finds frequent itemsets and generates association rules using support, confidence, and lift.

The implementation is inspired by the existing Apriori algorithm in the repo but adds:

1 - Support, confidence, and lift calculations for association rules.

2 - Confidence and lift as separate class methods for clarity and reuse.

3 - A load_data() example for demonstration and doctest purposes.

4 - Proper filtering of rules using minimum support, confidence, and lift thresholds.

References:

  • Wikipedia: Apriori algorithm

  • Example dataset: included in load_data() function for doctest.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Sep 6, 2025
@simoderyouch simoderyouch force-pushed the feature/apriori-association-rules branch from c3297f0 to 68a201c Compare September 6, 2025 18:53
@simoderyouch simoderyouch force-pushed the feature/apriori-association-rules branch from 95faadd to eca4fdb Compare September 6, 2025 18:57
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Sep 6, 2025
Copy link
Author

I’ve added a new custom Apriori algorithm implementation that:

  • Finds frequent itemsets
  • Generates association rules using support, confidence, and lift
  • Includes type hints, doctests, and clean style

✔️ All pre-commit and CI checks are passing.

Could someone please review and validate the code for merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /