Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Weierstrass Method #12877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CaedenPH merged 5 commits into TheAlgorithms:master from aditya7balotra:add-numerical-analysis
Aug 29, 2025
Merged

Conversation

Copy link
Contributor

@aditya7balotra aditya7balotra commented Aug 2, 2025 •
edited
Loading

  • Implements Durand-Kerner (Weierstrass) method for polynomial root finding
  • Accepts user-defined polynomial function and degree
  • Uses random perturbation of complex roots of unity for initial guesses
  • Handles validation, overflow clipping, and includes doctest

Describe your change:

This pull request adds an implementation of the Weierstrass (Durand–Kerner) method to numerically approximate all complex roots of a given polynomial. The function accepts a user-defined polynomial, its degree, and an optional initial guess for the roots. The implementation includes:

  1. Type annotations and detailed docstring

  2. Doctest to validate correctness

  3. Optional support for custom initial guesses

  4. Numerical safeguards (e.g., overflow clipping)

  5. A Wikipedia reference for further explanation

This method is useful in numerical analysis and computational algebra for finding all roots of a polynomial simultaneously using iterative refinement.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Aug 2, 2025
Copy link

helma436 commented Aug 4, 2025

Preparing review...

3 similar comments
Copy link

helma436 commented Aug 4, 2025

Preparing review...

Copy link

helma436 commented Aug 4, 2025

Preparing review...

Copy link

helma436 commented Aug 4, 2025

Preparing review...
aditya7balotra reacted with thumbs up emoji

Copy link

Currently, the method always runs max_iter iterations. Adding a tolerance (tol) and stopping early when updates are small would improve efficiency.

Copy link

For stability, sometimes using deflation or derivative checks helps avoid stagnation on multiple roots. Could be an optional enhancement.

Copy link

Constructing the full denominator matrix (degree x degree) is O(n2).
You might optimize by computing products without building a dense matrix.

Copy link
Contributor Author

Great feedback, @MrittikaDutta !
Your suggestions are really valuable, and I’ll consider implementing them soon.
Thanks a lot!

Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Requires some additional tests ideally with higher order, handling floats, does this algorithm handle complex roots, etc
If you add some more tests or commit my tests I'll merge this pr.

aditya7balotra reacted with thumbs up emoji
@CaedenPH CaedenPH added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Aug 28, 2025
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass and removed awaiting changes A maintainer has requested changes to this PR tests are failing Do not merge until tests pass labels Aug 28, 2025
aditya7balotra and others added 5 commits August 29, 2025 14:49 
- Implements Durand-Kerner (Weierstrass) method for polynomial root finding
- Accepts user-defined polynomial function and degree
- Uses random perturbation of complex roots of unity for initial guesses
- Handles validation, overflow clipping, and includes doctest
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more tests wouldn't go amiss but other than that looks good

@CaedenPH CaedenPH merged commit 4394fd9 into TheAlgorithms:master Aug 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedenPH CaedenPH CaedenPH approved these changes

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /